Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 200009: Use system themes where possible in Omnibox, dropdown, and security info bubb... (Closed)

Created:
11 years, 3 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Use system themes where possible in Omnibox edit and dropdown; in other cases, provide a pair of colors and use whichever contrasts more with the relevant background color, to maintain readability. BUG=92, 18367 TEST=Use the omnibox on various non-default and high-contrast system themes. Observe that everything is always readable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25494

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 17

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -152 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 2 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 2 3 7 chunks +20 lines, -26 lines 0 comments Download
M chrome/browser/toolbar_model.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/toolbar_model.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc View 1 2 3 7 chunks +75 lines, -66 lines 0 comments Download
M chrome/browser/views/info_bubble.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/views/location_bar_view.h View 3 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 2 3 10 chunks +87 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Kasting
I'm not sure that both TOOLKIT_VIEWS and non-TOOLKIT_VIEWS GTK builds will compile correctly with this ...
11 years, 3 months ago (2009-09-03 21:27:36 UTC) #1
sky
http://codereview.chromium.org/200009/diff/4001/4002 File chrome/browser/autocomplete/autocomplete_edit_view_win.cc (right): http://codereview.chromium.org/200009/diff/4001/4002#newcode2008 Line 2008: emphasize ? LocationBarView::DEEMPHASIZED_TEXT : LocationBarView::TEXT)); This seems weird. ...
11 years, 3 months ago (2009-09-03 23:26:58 UTC) #2
Peter Kasting
New snapshot uploaded. In this one I have added some temporary #ifs around the lines ...
11 years, 3 months ago (2009-09-04 00:47:08 UTC) #3
sky
This fails on linux toolkit_views with the following error: /usr/local/google/gold/ld: /secondary/builds/build3/src/sconsbuild/Debug/lib/libbrowser.a(autocomplete_edit_view_gtk.o): in function AutocompleteEditViewGtk::SetBaseColor():/secondary/builds/build3/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc:529: undefined ...
11 years, 3 months ago (2009-09-04 14:05:14 UTC) #4
Peter Kasting
On 2009/09/04 14:05:14, sky wrote: > This fails on linux toolkit_views with the following error: ...
11 years, 3 months ago (2009-09-04 18:33:18 UTC) #5
sky
11 years, 3 months ago (2009-09-04 19:48:53 UTC) #6
LGTM, and it compiles!

Powered by Google App Engine
This is Rietveld 408576698