Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2000073004: Remove the CHECKs in the DXVA code for the DX11 codepath (Closed)

Created:
4 years, 7 months ago by ananta
Modified:
4 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the CHECKs in the DXVA code for the DX11 codepath This has baked in the field for sometime now. In any case we are seeing sporadic crashes due to these CHECKs firing for buggy GPU's. While this will get rid of these crashes, we are probably going to see a spike in videos not playing reports in the near future. We can handle those as they come in. I replaced some of the CHECKs with DCHECKs to aid debugging in case these problems reproduce locally. BUG=611497, 495667 Committed: https://crrev.com/3ff0e39da6a98c7cc80dd04c70b25aa25bdb0015 Cr-Commit-Position: refs/heads/master@{#395705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -41 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.cc View 7 chunks +9 lines, -41 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
ananta
4 years, 7 months ago (2016-05-23 23:09:54 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 7 months ago (2016-05-23 23:12:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000073004/1
4 years, 7 months ago (2016-05-23 23:29:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/226758)
4 years, 7 months ago (2016-05-24 05:11:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000073004/1
4 years, 7 months ago (2016-05-24 19:04:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 21:40:32 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 21:41:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ff0e39da6a98c7cc80dd04c70b25aa25bdb0015
Cr-Commit-Position: refs/heads/master@{#395705}

Powered by Google App Engine
This is Rietveld 408576698