Clean up more XFA code which causes warnings

xfa/fgas/localization/fgas_locale.cpp

Index: xfa/fgas/localization/fgas_locale.cpp
diff --git a/xfa/fgas/localization/fgas_locale.cpp b/xfa/fgas/localization/fgas_locale.cpp
index 6eed202643be560631cae32223e267e1b11b953f..f0d1066397a220a0e644fcffba08abd151c22c48 100644
--- a/xfa/fgas/localization/fgas_locale.cpp
+++ b/xfa/fgas/localization/fgas_locale.cpp
@@ -3655,9 +3655,8 @@ FX_BOOL FX_TimeFromCanonical(const CFX_WideStringC& wsTime,
             }
             millisecond = millisecond * 10 + str[cc++] - '0';
           }
-          if (cc < cc_start + 3 || millisecond >= 1000) {
+          if (cc < cc_start + 3)

[Tom Sepez, 2016/05/23 16:57:54]

wow ... was there some compiler smart enough to know that this would always be <
1000?

[Wei Li, 2016/05/23 17:10:44]

Yes, GCC wants to optimize this away. It is not that easy to figure this out :)

             return FALSE;
-          }
         }
         if (cc < len) {
           FX_TIMEZONE tzDiff;