Clean up more XFA code which causes warnings

xfa/fgas/localization/fgas_locale.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <algorithm>
 
 #include "core/fxcrt/include/fx_ext.h"
 #include "core/fxcrt/include/fx_xml.h"
@@ skipping 3637 matching lines @@
       if (cc < len) {
         if (str[cc] == '.') {
           cc++;
           cc_start = cc;
           while (cc < len && cc < cc_start + 3) {
             if (!FX_IsDigit(str[cc])) {
               return FALSE;
             }
             millisecond = millisecond * 10 + str[cc++] - '0';
           }
-          if (cc < cc_start + 3 || millisecond >= 1000) {
+          if (cc < cc_start + 3)

[Tom Sepez, 2016/05/23 16:57:54]

wow ... was there some compiler smart enough to know that this would always be <
1000?

[Wei Li, 2016/05/23 17:10:44]

Yes, GCC wants to optimize this away. It is not that easy to figure this out :)

             return FALSE;
-          }
         }
         if (cc < len) {
           FX_TIMEZONE tzDiff;
           tzDiff.tzHour = 0;
           tzDiff.tzMinute = 0;
           if (str[cc] != 'Z') {
             cc += FX_ParseTimeZone(str + cc, len - cc, tzDiff);
           }
           FX_ResolveZone(hour, minute, tzDiff, pLocale);
         }
@@ skipping 1103 matching lines @@
 }
 CFX_Decimal CFX_Decimal::operator*(const CFX_Decimal& val) const {
   return Multiply(val);
 }
 CFX_Decimal CFX_Decimal::operator/(const CFX_Decimal& val) const {
   return Divide(val);
 }
 CFX_Decimal CFX_Decimal::operator%(const CFX_Decimal& val) const {
   return Modulus(val);
 }