Change FrameBlameContext's type from "Frame" to "RenderFrame"

Change FrameBlameContext's type from "Frame" to "RenderFrame"

This patch changes FrameBlameContext's type to keep it consistent with
trace viewer's tracing/extras/chrome/render_frame.html, so that the
traced FrameBlameContext objects can be instantiated correctly as
RenderFrameInstance/Snapshot instead of general ObjectInstance/Snapshot.

This also helps reducing the use of the heavily overloaded term "Frame".

BUG=546021
Committed: https://crrev.com/9b9e5ba584e32de6cf5202077b1cbe79a76619e6
Cr-Commit-Position: refs/heads/master@{#396340}

[Xiaocheng, 2016-05-26 08:56:02]

Description was changed from

==========
Change FrameBlameContext's type from "Frame" to "RenderFrame"

This patch changes FrameBlameContext's type to keep it align with trace
viewer's tracing/extras/chrome/render_frame.html, and also avoid using
the heavily overloaded term "Frame".

BUG=546021
==========

to

==========
Change FrameBlameContext's type from "Frame" to "RenderFrame"

This patch changes FrameBlameContext's type to keep it consistent with
trace viewer's tracing/extras/chrome/render_frame.html, so that the
traced FrameBlameContext objects can be instantiated correctly as
RenderFrameInstance/Snapshot instead of general ObjectInstance/Snapshot.

This also helps reducing the use of the heavily overloaded term "Frame".

BUG=546021
==========

[Xiaocheng, 2016-05-26 08:56:02]

xiaochengh@chromium.org changed reviewers:
+ creis@chromium.org, skyostil@chromium.org

[Xiaocheng, 2016-05-26 08:58:03]

PTAL.

In fact I'm wondering why FrameBlameContext uses "Frame" instead of
"RenderFrame" in the first place...

[Sami, 2016-05-26 10:47:56]

lgtm, it was really an arbitrary choice so I'm all for being more specific.

[Charlie Reis, 2016-05-26 23:20:07]

LGTM, since it appears that FrameBlameContext is specific to a RenderFrame{Host}
and not a FrameTreeNode (which can have different RenderFrame{Host}s over its
lifetime).

Note that I don't know much about BlameContext in terms of how this is used, but
it sounds plausible to me.  One other concern below.

https://codereview.chromium.org/2000063008/diff/1/content/renderer/frame_blam...
File content/renderer/frame_blame_context.cc (right):

https://codereview.chromium.org/2000063008/diff/1/content/renderer/frame_blam...
content/renderer/frame_blame_context.cc:36: render_frame->GetRoutingID(),
Unrelated: This scares me.  Are BlameContexts process-specific?  A routing ID
can't be treated as a globally unique ID, since renderer processes have
overlapping routing IDs.  This means that two separate RenderFrames will both
have routing ID 1, and could be given the same BlameContext ID.

[Charlie Reis, 2016-05-26 23:21:52]

https://codereview.chromium.org/2000063008/diff/1/content/renderer/frame_blam...
File content/renderer/frame_blame_context.cc (right):

https://codereview.chromium.org/2000063008/diff/1/content/renderer/frame_blam...
content/renderer/frame_blame_context.cc:36: render_frame->GetRoutingID(),
On 2016/05/26 23:20:07, Charlie Reis wrote:
> Unrelated: This scares me.  Are BlameContexts process-specific?  A routing ID
> can't be treated as a globally unique ID, since renderer processes have
> overlapping routing IDs.  This means that two separate RenderFrames will both
> have routing ID 1, and could be given the same BlameContext ID.

Ha, nevermind.  This is in the renderer process.  Proceed.  :)

[Xiaocheng, 2016-05-27 01:08:06]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-05-27 01:08:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000063008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000063008/1

[commit-bot: I haz the power, 2016-05-27 01:13:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-27 01:14:33]

Description was changed from

==========
Change FrameBlameContext's type from "Frame" to "RenderFrame"

This patch changes FrameBlameContext's type to keep it consistent with
trace viewer's tracing/extras/chrome/render_frame.html, so that the
traced FrameBlameContext objects can be instantiated correctly as
RenderFrameInstance/Snapshot instead of general ObjectInstance/Snapshot.

This also helps reducing the use of the heavily overloaded term "Frame".

BUG=546021
==========

to

==========
Change FrameBlameContext's type from "Frame" to "RenderFrame"

This patch changes FrameBlameContext's type to keep it consistent with
trace viewer's tracing/extras/chrome/render_frame.html, so that the
traced FrameBlameContext objects can be instantiated correctly as
RenderFrameInstance/Snapshot instead of general ObjectInstance/Snapshot.

This also helps reducing the use of the heavily overloaded term "Frame".

BUG=546021

Committed: https://crrev.com/9b9e5ba584e32de6cf5202077b1cbe79a76619e6
Cr-Commit-Position: refs/heads/master@{#396340}
==========

[commit-bot: I haz the power, 2016-05-27 01:14:34]

Patchset 1 (id:??) landed as
https://crrev.com/9b9e5ba584e32de6cf5202077b1cbe79a76619e6
Cr-Commit-Position: refs/heads/master@{#396340}