Define DiagnosticMap and a basic Diagnostic hierarchy

tracing/tracing/value/value_test.html

Index: tracing/tracing/value/value_test.html
diff --git a/tracing/tracing/value/value_test.html b/tracing/tracing/value/value_test.html
index b5c7d7a464fe33215e12eb5d1aece33753d169ed..07e73b030eed971fb53fdb44b0f89104e1f7aeb8 100644
--- a/tracing/tracing/value/value_test.html
+++ b/tracing/tracing/value/value_test.html
@@ -15,9 +15,8 @@ found in the LICENSE file.
 
 tr.b.unittest.testSuite(function() {
   test('numericValueBasic', function() {
-    var canonicalUrl = 'my_test.json';
     var n = new tr.v.ScalarNumeric(tr.v.Unit.byName.sizeInBytes, 314);
-    var v = new tr.v.NumericValue(canonicalUrl, 'MyNumeric', n);
+    var v = new tr.v.NumericValue('MyNumeric', n);
     assert.isDefined(v.guid);
     var d = v.asDict();
 
@@ -26,26 +25,22 @@ tr.b.unittest.testSuite(function() {
     assert.equal(v.guid, v2.guid);
     assert.equal(v.name, v2.name);
     assert.equal(v.numeric.value, v2.numeric.value);
-    assert.equal(v.canonicalUrl, v2.canonicalUrl);
   });
 
   test('dictValueBasic', function() {
-    var canonicalUrl = 'my_test.json';
-    var v = new tr.v.DictValue(canonicalUrl, 'MyDict', {my_key: 'my_value'});
+    var v = new tr.v.DictValue('MyDict', {my_key: 'my_value'});
     assert.isDefined(v.guid);
     var d = v.asDict();
 
     var v2 = tr.v.Value.fromDict(d);
     assert.instanceOf(v2, tr.v.DictValue);
     assert.equal(v.guid, v2.guid);
-    assert.equal(v.groupingKeys.value_name, v2.groupingKeys.value_name);
     assert.deepEqual(v.value, v2.value);
   });
 
   test('failureValueBasic', function() {
-    var canonicalUrl = 'my_test.json';
     var v = new tr.v.FailureValue(
-      canonicalUrl, 'MyFailure',
+      'MyFailure',
       {description: 'Description', stack: tr.b.stackTraceAsString()});
     assert.isDefined(v.guid);
     var d = v.asDict();
@@ -56,12 +51,10 @@ tr.b.unittest.testSuite(function() {
     assert.equal(v.name, v2.name);
     assert.equal(v.description, v2.description);
     assert.equal(v.stack, v2.stack);
-    assert.equal(v.diagnostics.canonical_url, v2.diagnostics.canonical_url);
   });
 
   test('skipValueBasic', function() {
-    var canonicalUrl = 'my_test.json';
-    var v = new tr.v.SkipValue(canonicalUrl, 'MySkip',
+    var v = new tr.v.SkipValue('MySkip',
                                {description: 'WhySkipped'});
     assert.isDefined(v.guid);
     var d = v.asDict();
@@ -69,61 +62,31 @@ tr.b.unittest.testSuite(function() {
     var v2 = tr.v.Value.fromDict(d);
     assert.equal(v.guid, v2.guid);
     assert.instanceOf(v2, tr.v.SkipValue);
-    assert.equal(v.groupingKeys.value_name, v2.groupingKeys.value_name);
     assert.equal(v.description, v2.description);
   });
 
-  test('addGroupingKey', function() {
-    var canonicalUrl = 'my_test.json';
-    var n = new tr.v.ScalarNumeric(tr.v.Unit.byName.sizeInBytes, 314);
-    var v = new tr.v.NumericValue(canonicalUrl, 'MyScalar', n);
-
-    v.addGroupingKey('foo', 'bar');
-    assert.equal(v.groupingKeys.foo, 'bar');
-  });
-
-  test('addDuplicateGroupingKeyThrows', function() {
-    var canonicalUrl = 'my_test.json';
-    var n = new tr.v.ScalarNumeric(tr.v.Unit.byName.sizeInBytes, 314);
-    var v = new tr.v.NumericValue(canonicalUrl, 'MyScalar', n);
-
-    assert.throws(function() { v.addGroupingKey('name', 'bar'); });
-  });
-
-  test('nameGroupingKeyThrows', function() {
-    var canonicalUrl = 'my_test.json';
-    var n = new tr.v.ScalarNumeric(tr.v.Unit.byName.sizeInBytes, 314);
-    var options = {};
-    var groupingKeys = {name: 'bar'};
-    assert.throws(function() {
-      new tr.v.NumericValue(
-          canonicalUrl, 'MyScalar', n, options, groupingKeys);
-    });
-  });
-
-  test('reUseGroupingKeys', function() {
-    var canonicalUrl = 'my_test.json';
-    var options = {};
-    var groupingKeys = {a: 'b', c: 'd'};
-    var bytesNumeric = new tr.v.ScalarNumeric(
-        tr.v.Unit.byName.sizeInBytes, 314);
-    var bytesValue = new tr.v.NumericValue(
-        canonicalUrl, 'bytes', bytesNumeric, options, groupingKeys);
-    var latencyNumeric = new tr.v.ScalarNumeric(
-        tr.v.Unit.byName.timeDurationInMs, 314);
-    var latencyValue = new tr.v.NumericValue(
-        canonicalUrl, 'latency', latencyNumeric, options, groupingKeys);
-
-    var bytesValueDict = bytesValue.asDict();
-    var latencyValueDict = latencyValue.asDict();
-
-    assert.equal('bytes', bytesValueDict.grouping_keys.name);
-    assert.equal('b', bytesValueDict.grouping_keys.a);
-    assert.equal('d', bytesValueDict.grouping_keys.c);
-    assert.equal('latency', latencyValueDict.grouping_keys.name);
-    assert.equal('b', latencyValueDict.grouping_keys.a);
-    assert.equal('d', latencyValueDict.grouping_keys.c);
+  test('genericDiagnostic', function() {
+    var skip = new tr.v.SkipValue('skip');
+    skip.diagnostics.add('foo', new tr.v.d.Generic({
+      t: true,
+      f: false,
+      z: 0,
+      o: 1,
+      ans: 0.42,
+      s: 'string',
+      a: [42.42, 'more string'],
+      d: {a: {b: 'c'}}
+    }));
+    var skip2 = tr.v.Value.fromDict(skip.asDict());
+    var foo2 = skip2.diagnostics.get('foo');
+    assert.strictEqual(true, foo2.value.t);
+    assert.strictEqual(false, foo2.value.f);
+    assert.strictEqual(0, foo2.value.z);
+    assert.strictEqual(1, foo2.value.o);
+    assert.strictEqual(0.42, foo2.value.ans);
+    assert.strictEqual('string', foo2.value.s);
+    assert.deepEqual([42.42, 'more string'], foo2.value.a);
+    assert.deepEqual({a: {b: 'c'}}, foo2.value.d);
   });
 });
-
 </script>