Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: tracing/tracing/ui/analysis/single_user_expectation_sub_view.html

Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/value_set_test.html ('k') | tracing/tracing/value/diagnostics/composition.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/analysis/single_user_expectation_sub_view.html
diff --git a/tracing/tracing/ui/analysis/single_user_expectation_sub_view.html b/tracing/tracing/ui/analysis/single_user_expectation_sub_view.html
index 46f688937dd6c90baa449df5d9ebfbb156dc3cec..96d2842ae167cda06971137f4d909e6c1c5db76b 100644
--- a/tracing/tracing/ui/analysis/single_user_expectation_sub_view.html
+++ b/tracing/tracing/ui/analysis/single_user_expectation_sub_view.html
@@ -67,43 +67,6 @@ found in the LICENSE file.
onCustomizeRows_: function(event) {
var ue = tr.b.getOnlyElement(this.selection);
- var values = new tr.metrics.ValueSet();
-
- function runMetric(metricInfo) {
- try {
- metricInfo.constructor(values, ue.parentModel);
- } catch (failure) {
- console.error(metricInfo, failure);
- }
- }
-
- tr.metrics.MetricRegistry.getAllRegisteredTypeInfos().forEach(runMetric);
-
- // Metrics may have been computed more than once, so avoid displaying them
- // more than once by collecting them in a dictionary.
- // https://github.com/catapult-project/catapult/issues/2154
- var metricValues = {};
-
- values.valueDicts.forEach(function(value) {
- if (value.grouping_keys.userExpectationStableId !== ue.stableId)
- return;
-
- if ((value.type !== 'numeric') ||
- (value.numeric.type !== 'scalar'))
- return;
-
- metricValues[value.grouping_keys.name] = value.numeric;
- });
-
- for (var name in metricValues) {
- event.rows.push({
- name: name,
- value: tr.v.ui.createScalarSpan(metricValues[name].value, {
- unit: tr.v.Unit.fromJSON(metricValues[name].unit)
- })
- });
- }
-
if (ue.rawCpuMs) {
event.rows.push({
name: 'Total CPU',
« no previous file with comments | « tracing/tracing/metrics/value_set_test.html ('k') | tracing/tracing/value/diagnostics/composition.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698