Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: tracing/tracing/metrics/v8/gc_metric.html

Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/v8/execution_metric.html ('k') | tracing/tracing/metrics/v8/gc_metric_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/v8/gc_metric.html
diff --git a/tracing/tracing/metrics/v8/gc_metric.html b/tracing/tracing/metrics/v8/gc_metric.html
index 19d3b172cafcc407254dac83454ec568e152a128..6354cd289c25dcce2b89b7a8a39cafa319e546f1 100644
--- a/tracing/tracing/metrics/v8/gc_metric.html
+++ b/tracing/tracing/metrics/v8/gc_metric.html
@@ -103,8 +103,7 @@ tr.exportTo('tr.metrics.v8', function() {
events.forEach(function(event) {
cpuDuration.add(event.cpuDuration);
});
- values.addValue(
- new tr.v.NumericValue(model.canonicalUrl,
+ values.addValue(new tr.v.NumericValue(
stageTitle + '-' + name, cpuDuration));
}
);
@@ -123,8 +122,7 @@ tr.exportTo('tr.metrics.v8', function() {
events.forEach(function(event) {
cpuDuration.add(event.cpuDuration);
});
- values.addValue(
- new tr.v.NumericValue(model.canonicalUrl,
+ values.addValue(new tr.v.NumericValue(
stageTitle + '-' + name, cpuDuration));
}
);
@@ -143,8 +141,7 @@ tr.exportTo('tr.metrics.v8', function() {
events.forEach(function(event) {
cpuDuration.add(event.cpuDuration);
});
- values.addValue(
- new tr.v.NumericValue(model.canonicalUrl,
+ values.addValue(new tr.v.NumericValue(
stageTitle + '-' + name, cpuDuration));
}
);
@@ -211,17 +208,14 @@ tr.exportTo('tr.metrics.v8', function() {
outsideIdle.add(event.cpuDuration - inside);
idleDeadlineOverrun.add(overrun);
});
- values.addValue(
- new tr.v.NumericValue(model.canonicalUrl,
+ values.addValue(new tr.v.NumericValue(
stageTitle + '-' + name + '_idle_deadline_overrun',
idleDeadlineOverrun));
- values.addValue(
- new tr.v.NumericValue(model.canonicalUrl,
+ values.addValue(new tr.v.NumericValue(
stageTitle + '-' + name + '_outside_idle', outsideIdle));
var percentage = createPercentage(insideIdle.sum,
cpuDuration.sum);
- values.addValue(
- new tr.v.NumericValue(model.canonicalUrl,
+ values.addValue(new tr.v.NumericValue(
stageTitle + '-' + name + '_percentage_idle', percentage));
}
@@ -251,14 +245,14 @@ tr.exportTo('tr.metrics.v8', function() {
[0.90, 0.95, 0.99].forEach(function(percent) {
var value = new tr.v.ScalarNumeric(percentage_biggerIsBetter,
mutatorUtilization.percentile(1.0 - percent) * 100);
- values.addValue(new tr.v.NumericValue(model.canonicalUrl,
+ values.addValue(new tr.v.NumericValue(
stageTitle + '-v8-execute-mutator-utilization_pct_0' +
percent * 100,
value));
});
var value = new tr.v.ScalarNumeric(percentage_biggerIsBetter,
mutatorUtilization.min);
- values.addValue(new tr.v.NumericValue(model.canonicalUrl,
+ values.addValue(new tr.v.NumericValue(
stageTitle + '-v8-execute-mutator-utilization_min', value));
}
);
« no previous file with comments | « tracing/tracing/metrics/v8/execution_metric.html ('k') | tracing/tracing/metrics/v8/gc_metric_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698