telemetry/telemetry/value/common_value_helpers.py - Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/value/common_value_helpers.py

Issue 2000063006: Define DiagnosticMap and a basic Diagnostic hierarchy (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/results/html2_output_formatter.py ('k') | telemetry/telemetry/value/common_value_helpers_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/value/common_value_helpers.py

diff --git a/telemetry/telemetry/value/common_value_helpers.py b/telemetry/telemetry/value/common_value_helpers.py

index 9169acfd9209b680c6702037aa512bc101b09d2b..2073a83bd74d3f5f18a01bb84cfc742a4fd39fc3 100644

--- a/telemetry/telemetry/value/common_value_helpers.py

+++ b/telemetry/telemetry/value/common_value_helpers.py

@@ -24,7 +24,7 @@ def TranslateScalarValue(scalar_value, page):

if value is None:

scalar_value['none_value_reason'] = 'Common scalar contained None'

- name = scalar_value['grouping_keys']['name']

+ name = scalar_value['name']

unit_parts = scalar_value['numeric']['unit'].split('_')

if len(unit_parts) != 2:

@@ -42,7 +42,6 @@ def TranslateScalarValue(scalar_value, page):

scalar_value['page_id'] = page.id

scalar_value['name'] = name

- del scalar_value['grouping_keys']['name']

return scalar.ScalarValue.FromDict(scalar_value, {page.id: page})