Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000063004: MD Settings: fix favicon (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix favicon This makes the favicon (icon in the tab handle) a cog like old settings. R=dschuyler@chromium.org BUG=614245 Committed: https://crrev.com/759bada2b858177a3cefd689b0babe113b6b171c Cr-Commit-Position: refs/heads/master@{#395749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/settings_utils.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings_utils.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Beam
4 years, 7 months ago (2016-05-24 03:27:14 UTC) #1
dschuyler
lgtm
4 years, 7 months ago (2016-05-24 20:26:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000063004/1
4 years, 7 months ago (2016-05-25 00:20:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 00:26:08 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 00:27:24 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/759bada2b858177a3cefd689b0babe113b6b171c
Cr-Commit-Position: refs/heads/master@{#395749}

Powered by Google App Engine
This is Rietveld 408576698