Source/core/html/HTMLCanvasElement.cpp - Issue 200003002: Canvas element that use the alpha attribute don't display correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCanvasElement.cpp

Issue 200003002: Canvas element that use the alpha attribute don't display correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: layout test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLCanvasElement.cpp

diff --git a/Source/core/html/HTMLCanvasElement.cpp b/Source/core/html/HTMLCanvasElement.cpp

index 4ea22121fa982da6aa7d0e3754e0d820cd904e05..a747a9fba20d8e34f9b44f7442102a9f666630af 100644

--- a/Source/core/html/HTMLCanvasElement.cpp

+++ b/Source/core/html/HTMLCanvasElement.cpp

@@ -315,6 +315,10 @@ void HTMLCanvasElement::paint(GraphicsContext* context, const LayoutRect& r, boo

if (!paintsIntoCanvasBuffer() && !document().printing())

return;

m_context->paintRenderingResultsToCanvas();

+ // When alpha is false, we should initialize to opaque black.

+ if (!hasImageBuffer() && !m_context->hasAlpha())

+ createImageBuffer();

Justin Novosad 2014/03/17 17:24:23 I think you can solve this problem without creatin

}

if (hasImageBuffer()) {

« no previous file with comments | « LayoutTests/fast/canvas/alpha.js ('k') | no next file » | no next file with comments »