Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000023002: Tidy AutoplayExperimentHelper. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy AutoplayExperimentHelper. Remove unused and undefineds. R= BUG= Committed: https://crrev.com/f019a189adb0e6536646845ec7b152ab47dfb62d Cr-Commit-Position: refs/heads/master@{#395286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -24 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h View 3 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. discovered while looking at dispose() usage in the codebase.
4 years, 7 months ago (2016-05-22 07:53:41 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-22 09:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000023002/1
4 years, 7 months ago (2016-05-23 05:19:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 05:23:29 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 05:24:50 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f019a189adb0e6536646845ec7b152ab47dfb62d
Cr-Commit-Position: refs/heads/master@{#395286}

Powered by Google App Engine
This is Rietveld 408576698