Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: content/renderer/media/video_track_recorder.h

Issue 2000003002: Initialize based on frame sizes in VideoTrackRecorder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mrgpu2
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/video_track_recorder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/video_track_recorder.h
diff --git a/content/renderer/media/video_track_recorder.h b/content/renderer/media/video_track_recorder.h
index 5e624549224362132c2a842d31db65ae3d0369d6..e8de7d96614cdd8dd64e5f198fe4a077ff70be98 100644
--- a/content/renderer/media/video_track_recorder.h
+++ b/content/renderer/media/video_track_recorder.h
@@ -9,6 +9,8 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
+#include "base/single_thread_task_runner.h"
#include "base/threading/thread_checker.h"
#include "content/public/common/features.h"
#include "content/public/renderer/media_stream_video_sink.h"
@@ -18,6 +20,11 @@ namespace media {
class VideoFrame;
} // namespace media
+namespace video_track_recorder {
+const int kVEAEncoderMinResolutionWidth = 640;
+const int kVEAEncoderMinResolutionHeight = 480;
+} // namespace video_track_recorder
+
namespace content {
// VideoTrackRecorder is a MediaStreamVideoSink that encodes the video frames
@@ -56,6 +63,12 @@ class CONTENT_EXPORT VideoTrackRecorder
private:
friend class VideoTrackRecorderTest;
+ void InitializeEncoder(CodecId codec,
+ const OnEncodedVideoCB& on_encoded_video_callback,
+ int32_t bits_per_second,
+ const scoped_refptr<media::VideoFrame>& frame,
+ base::TimeTicks capture_time);
+
// Used to check that we are destroyed on the same thread we were created.
base::ThreadChecker main_render_thread_checker_;
@@ -65,6 +78,15 @@ class CONTENT_EXPORT VideoTrackRecorder
// Inner class to encode using whichever codec is configured.
scoped_refptr<Encoder> encoder_;
+ base::Callback<void(const scoped_refptr<media::VideoFrame>& frame,
+ base::TimeTicks capture_time)>
+ initialize_encoder_callback_;
mcasas 2016/07/12 15:41:12 Make const and put it in the initializer list inst
emircan 2016/07/12 17:39:24 I cannot. I use weak_ptr_factory_.GetWeakPtr() and
+
+ // Used to track the paused state during the initialization process.
+ bool paused_before_init_;
+
+ base::WeakPtrFactory<VideoTrackRecorder> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(VideoTrackRecorder);
};
« no previous file with comments | « no previous file | content/renderer/media/video_track_recorder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698