Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 1999943002: Moving HTTP POST body from StartNavigationParams to CommonNavigationParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR feedback from clamy@. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index cb64dc8880b575a8b9d68095f688b4de3ade8ef9..66e704b648beab8b84cd58306ea269f387759cda 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -2252,15 +2252,14 @@ void ResourceDispatcherHostImpl::BeginNavigationRequest(
GetChromeBlobStorageContextForResourceContext(resource_context));
// Resolve elements from request_body and prepare upload data.
- if (info.request_body.get()) {
- AttachRequestBodyBlobDataHandles(
- info.request_body.get(),
- blob_context);
+ ResourceRequestBody* body = info.common_params.post_data.get();
+ if (body) {
+ AttachRequestBodyBlobDataHandles(body, blob_context);
// TODO(davidben): The FileSystemContext is null here. In the case where
// another renderer requested this navigation, this should be the same
// FileSystemContext passed into ShouldServiceRequest.
new_request->set_upload(UploadDataStreamBuilder::Build(
- info.request_body.get(),
+ body,
blob_context,
nullptr, // file_system_context
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)
@@ -2325,7 +2324,8 @@ void ResourceDispatcherHostImpl::BeginNavigationRequest(
ServiceWorkerRequestHandler::InitializeForNavigation(
new_request.get(), service_worker_handle_core, blob_context,
info.begin_params.skip_service_worker, resource_type,
- info.begin_params.request_context_type, frame_type, info.request_body);
+ info.begin_params.request_context_type, frame_type,
+ info.common_params.post_data);
// TODO(davidben): Attach AppCacheInterceptor.
« no previous file with comments | « content/browser/loader/navigation_url_loader_unittest.cc ('k') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698