Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 1999943002: Moving HTTP POST body from StartNavigationParams to CommonNavigationParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR feedback from clamy@. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_entry_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/memory/scoped_vector.h" 12 #include "base/memory/scoped_vector.h"
13 #include "base/time/time.h" 13 #include "base/time/time.h"
14 #include "build/build_config.h" 14 #include "build/build_config.h"
15 #include "content/browser/frame_host/frame_navigation_entry.h" 15 #include "content/browser/frame_host/frame_navigation_entry.h"
16 #include "content/browser/frame_host/frame_tree_node.h" 16 #include "content/browser/frame_host/frame_tree_node.h"
17 #include "content/browser/site_instance_impl.h" 17 #include "content/browser/site_instance_impl.h"
18 #include "content/common/frame_message_enums.h" 18 #include "content/common/frame_message_enums.h"
19 #include "content/public/browser/favicon_status.h" 19 #include "content/public/browser/favicon_status.h"
20 #include "content/public/browser/global_request_id.h" 20 #include "content/public/browser/global_request_id.h"
21 #include "content/public/browser/navigation_entry.h" 21 #include "content/public/browser/navigation_entry.h"
22 #include "content/public/common/page_state.h" 22 #include "content/public/common/page_state.h"
23 #include "content/public/common/ssl_status.h" 23 #include "content/public/common/ssl_status.h"
24 24
25 namespace content { 25 namespace content {
26 class ResourceRequestBody;
26 struct CommonNavigationParams; 27 struct CommonNavigationParams;
27 struct RequestNavigationParams; 28 struct RequestNavigationParams;
28 struct StartNavigationParams; 29 struct StartNavigationParams;
29 30
30 class CONTENT_EXPORT NavigationEntryImpl 31 class CONTENT_EXPORT NavigationEntryImpl
31 : public NON_EXPORTED_BASE(NavigationEntry) { 32 : public NON_EXPORTED_BASE(NavigationEntry) {
32 public: 33 public:
33 // Represents a tree of FrameNavigationEntries that make up this joint session 34 // Represents a tree of FrameNavigationEntries that make up this joint session
34 // history item. The tree currently only tracks the main frame by default, 35 // history item. The tree currently only tracks the main frame by default,
35 // and is populated with subframe nodes in --site-per-process mode. 36 // and is populated with subframe nodes in --site-per-process mode.
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 // TODO(creis): Once we start sharing FrameNavigationEntries between 153 // TODO(creis): Once we start sharing FrameNavigationEntries between
153 // NavigationEntryImpls, we will need to support two versions of Clone: one 154 // NavigationEntryImpls, we will need to support two versions of Clone: one
154 // that shares the existing FrameNavigationEntries (for use within the same 155 // that shares the existing FrameNavigationEntries (for use within the same
155 // tab) and one that draws them from a different pool (for use in a new tab). 156 // tab) and one that draws them from a different pool (for use in a new tab).
156 std::unique_ptr<NavigationEntryImpl> CloneAndReplace( 157 std::unique_ptr<NavigationEntryImpl> CloneAndReplace(
157 FrameTreeNode* frame_tree_node, 158 FrameTreeNode* frame_tree_node,
158 FrameNavigationEntry* frame_entry) const; 159 FrameNavigationEntry* frame_entry) const;
159 160
160 // Helper functions to construct NavigationParameters for a navigation to this 161 // Helper functions to construct NavigationParameters for a navigation to this
161 // NavigationEntry. 162 // NavigationEntry.
163 scoped_refptr<ResourceRequestBody> ConstructBodyFromBrowserInitiatedPostData()
164 const;
162 CommonNavigationParams ConstructCommonNavigationParams( 165 CommonNavigationParams ConstructCommonNavigationParams(
163 const FrameNavigationEntry& frame_entry, 166 const FrameNavigationEntry& frame_entry,
167 const scoped_refptr<ResourceRequestBody>& post_body,
164 const GURL& dest_url, 168 const GURL& dest_url,
165 const Referrer& dest_referrer, 169 const Referrer& dest_referrer,
166 FrameMsg_Navigate_Type::Value navigation_type, 170 FrameMsg_Navigate_Type::Value navigation_type,
167 LoFiState lofi_state, 171 LoFiState lofi_state,
168 const base::TimeTicks& navigation_start) const; 172 const base::TimeTicks& navigation_start) const;
169 StartNavigationParams ConstructStartNavigationParams() const; 173 StartNavigationParams ConstructStartNavigationParams() const;
170 RequestNavigationParams ConstructRequestNavigationParams( 174 RequestNavigationParams ConstructRequestNavigationParams(
171 const FrameNavigationEntry& frame_entry, 175 const FrameNavigationEntry& frame_entry,
172 bool is_same_document_history_load, 176 bool is_same_document_history_load,
173 bool has_committed_real_load, 177 bool has_committed_real_load,
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 // persisted, unless specific data is taken out/put back in at save/restore 507 // persisted, unless specific data is taken out/put back in at save/restore
504 // time (see TabNavigation for an example of this). 508 // time (see TabNavigation for an example of this).
505 std::map<std::string, base::string16> extra_data_; 509 std::map<std::string, base::string16> extra_data_;
506 510
507 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl); 511 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
508 }; 512 };
509 513
510 } // namespace content 514 } // namespace content
511 515
512 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 516 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_entry_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698