Issue 199993005: Fix branch for resetting change log in push-to-trunk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199993005: Fix branch for resetting change log in push-to-trunk. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, Jarin

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix branch for resetting change log in push-to-trunk. The patch is applied to ChangeLog with the "--index" option, which already updates the index of the file. For resetting the ChangeLog to the trunk revision, the trunk branch needs to be stated explicitly in the checkout, otherwise it checks out the already patched HEAD. TEST=tools/push-to-trunk/script_test.py R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19996

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -4 lines)			Patch
M	tools/push-to-trunk/git_recipes.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

6 years, 9 months ago (2014-03-17 13:52:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19996 (presubmit successful).

Expand Messages | Collapse Messages