Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Issue 199993003: android: Remove last md5sum call from java.gypi. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

android: Remove last md5sum call from java.gypi. process_resources writes all inputs to a filelist, and then passes the md5sum of the filelist as parameter (so that the commandline changes when inputs are removed, causing a rerun). Instead, just make the input filelist another input. gyp writes filelists when their contents change, so this means if inputs are removed, the mtime of the filelist will change, also causing a rebuild. No intended behavior change. BUG=177552 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M build/android/gyp/process_resources.py View 1 chunk +0 lines, -3 lines 0 comments Download
M build/java.gypi View 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 9 months ago (2014-03-15 07:35:39 UTC) #1
cjhopman
lgtm
6 years, 9 months ago (2014-03-17 17:36:26 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-17 17:56:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/199993003/1
6 years, 9 months ago (2014-03-17 17:57:42 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 17:59:56 UTC) #5
Message was sent while issue was closed.
Change committed as 257464

Powered by Google App Engine
This is Rietveld 408576698