Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 1999923002: Move the Google Payments URL functions out of content. (Closed)

Created:
4 years, 7 months ago by Justin Donnelly
Modified:
4 years, 7 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the Google Payments URL functions out of content. According to a comment in the code, switches::kReduceSecurityForTesting (which is the only requirement for this class to be in content) was used for requestAutocomplete testing. Now that requestAutocomplete has been removed, these functions can be moved out of components/autofill/content into components/autofill/core. Also, remove the kWalletServiceUrl and kWalletSecureServiceUrl switches. The former isn't referenced by any code and the while the latter is still referenced, the only mention I can find for the use of that flag is in a 3 year old thread* that later goes on to specify a different set of instructions that don't include the use of the flag. Finally, make some progress on s/Wallet/Payments. BUG=613281 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4 Cr-Commit-Position: refs/heads/master@{#395343}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -556 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/autofill_options_list.js View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/startup/bad_flags_prompt.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/autofill.gypi View 3 chunks +2 lines, -3 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 2 chunks +2 lines, -5 lines 0 comments Download
A + components/autofill/content/browser/payments/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/autofill/content/browser/payments/payments_client_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D components/autofill/content/browser/wallet/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D components/autofill/content/browser/wallet/payments_client_unittest.cc View 1 chunk +0 lines, -284 lines 0 comments Download
D components/autofill/content/browser/wallet/wallet_service_url.h View 1 chunk +0 lines, -25 lines 0 comments Download
D components/autofill/content/browser/wallet/wallet_service_url.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D components/autofill/content/browser/wallet/wallet_service_url_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 4 chunks +7 lines, -4 lines 0 comments Download
M components/autofill/core/browser/payments/payments_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/payments/payments_client.cc View 4 chunks +2 lines, -25 lines 0 comments Download
A components/autofill/core/browser/payments/payments_service_url.h View 1 chunk +33 lines, -0 lines 0 comments Download
A + components/autofill/core/browser/payments/payments_service_url.cc View 6 chunks +11 lines, -25 lines 0 comments Download
A + components/autofill/core/browser/payments/payments_service_url_unittest.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Justin Donnelly
The thread referencing the old flag can be found at https://goto.google.com/xjnbc.
4 years, 7 months ago (2016-05-20 21:25:44 UTC) #2
Justin Donnelly
4 years, 7 months ago (2016-05-20 21:46:01 UTC) #6
Evan Stade
lgtm
4 years, 7 months ago (2016-05-20 21:48:24 UTC) #7
Evan Stade
On 2016/05/20 21:48:24, Evan Stade wrote: > lgtm (rubber stamp)
4 years, 7 months ago (2016-05-20 21:48:42 UTC) #8
Justin Donnelly
+scottmg for build/common.gypi +pkasting for chrome/browser/ui/startup/bad_flags_prompt.cc
4 years, 7 months ago (2016-05-20 22:31:48 UTC) #10
Peter Kasting
LGTM
4 years, 7 months ago (2016-05-20 22:34:01 UTC) #11
scottmg
build lgtm
4 years, 7 months ago (2016-05-20 22:45:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999923002/20001
4 years, 7 months ago (2016-05-23 15:45:43 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-23 17:03:07 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 17:05:06 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4
Cr-Commit-Position: refs/heads/master@{#395343}

Powered by Google App Engine
This is Rietveld 408576698