media/test/pipeline_integration_test_base.cc - Issue 1999893004: Splits PipelineImpl into main and media thread components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/test/pipeline_integration_test_base.cc

Issue 1999893004: Splits PipelineImpl into main and media thread components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: restores posting stop done_cb Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/test/pipeline_integration_test_base.cc

diff --git a/media/test/pipeline_integration_test_base.cc b/media/test/pipeline_integration_test_base.cc

index 56b50871ca286d3a983f411d4bfbb94f57520903..42e3511c142709c62da8dfb436d9333888dd5288 100644

--- a/media/test/pipeline_integration_test_base.cc

+++ b/media/test/pipeline_integration_test_base.cc

@@ -53,10 +53,11 @@ PipelineIntegrationTestBase::PipelineIntegrationTestBase()

}

PipelineIntegrationTestBase::~PipelineIntegrationTestBase() {

- if (!pipeline_->IsRunning())

- return;

+ if (pipeline_->IsRunning())

+ Stop();

- Stop();

+ pipeline_.reset();

+ message_loop_.RunUntilIdle();

}

// TODO(xhwang): Method definitions in this file needs to be reordered.

« no previous file with comments | « media/test/pipeline_integration_test.cc ('k') | no next file » | no next file with comments »