[DevTools] Move CommandLineAPI.getEventListeners to native

[DevTools] Move CommandLineAPI.getEventListeners to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c
Cr-Commit-Position: refs/heads/master@{#395252}

[kozy, 2016-05-20 17:17:45]

Patchset #1 (id:1) has been deleted

[kozy, 2016-05-20 17:17:54]

Description was changed from

==========
[DevTools] Move CommandLineAPI.getEventListeners to native

It's last part of CommandLineAPI in InjectedScriptSource.js.

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move CommandLineAPI.getEventListeners to native

BUG=595206
R=dgozman@chromium.org
==========

[kozy, 2016-05-20 17:18:03]

Patchset #1 (id:20001) has been deleted

[kozy, 2016-05-20 17:19:46]

Dmitry, please take a look!

[dgozman, 2016-05-20 18:48:21]

lgtm

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h (right):

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h:1: // Copyright
2016 The Chromium Authors. All rights reserved.
2015

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right):

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:280:
options.setCapture(v8::Local<v8::Boolean>::Cast(thisUseCapture)->Value());
// TODO(dtapuska): we should pass "passive" flag as well, but there is no such
API yet.

[dtapuska, 2016-05-20 18:50:49]

dtapuska@chromium.org changed reviewers:
+ dtapuska@chromium.org

[dtapuska, 2016-05-20 18:50:50]

Note this will make https://codereview.chromium.org/1950403002/ much easier...

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right):

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:280:
options.setCapture(v8::Local<v8::Boolean>::Cast(thisUseCapture)->Value());
On 2016/05/20 18:48:21, dgozman wrote:
> // TODO(dtapuska): we should pass "passive" flag as well, but there is no such
> API yet.

No remove; doesn't have a passive flag. It isn't a filter for remove.

[kozy, 2016-05-20 18:52:35]

Patchset #2 (id:60001) has been deleted

[kozy, 2016-05-20 18:56:58]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-05-20 18:56:59]

All done.

@pfeldman, I need owner lgtm for it, please take a look!.
@dtapuska, sounds good, thanks for review.

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h (right):

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h:1: // Copyright
2016 The Chromium Authors. All rights reserved.
On 2016/05/20 18:48:21, dgozman wrote:
> 2015

Done.

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right):

https://codereview.chromium.org/1999843002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:280:
options.setCapture(v8::Local<v8::Boolean>::Cast(thisUseCapture)->Value());
On 2016/05/20 18:50:50, dtapuska wrote:
> On 2016/05/20 18:48:21, dgozman wrote:
> > // TODO(dtapuska): we should pass "passive" flag as well, but there is no
such
> > API yet.
> 
> No remove; doesn't have a passive flag. It isn't a filter for remove.

Done.

[pfeldman, 2016-05-21 01:05:46]

lgtm

[kozy, 2016-05-21 03:01:37]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-05-21 03:01:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1999843002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-21 03:01:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999843002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999843002/80001

[commit-bot: I haz the power, 2016-05-21 03:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-21 03:03:59]

Try jobs failed on following builders:
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[kozy, 2016-05-21 04:01:08]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-05-21 04:01:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1999843002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-05-21 04:01:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999843002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999843002/100001

[commit-bot: I haz the power, 2016-05-21 07:04:08]

Description was changed from

==========
[DevTools] Move CommandLineAPI.getEventListeners to native

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move CommandLineAPI.getEventListeners to native

BUG=595206
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-05-21 07:04:10]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-05-21 07:05:44]

Description was changed from

==========
[DevTools] Move CommandLineAPI.getEventListeners to native

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move CommandLineAPI.getEventListeners to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c
Cr-Commit-Position: refs/heads/master@{#395252}
==========

[commit-bot: I haz the power, 2016-05-21 07:05:46]

Patchset 3 (id:??) landed as
https://crrev.com/fa27658be9d81ff128fea23ef4830209202ca31c
Cr-Commit-Position: refs/heads/master@{#395252}