src/compiler/js-generic-lowering.cc - Issue 1999783004: [turbofan] Correctly call ArrayNoArgumentConstructor stub from TF code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 1999783004: [turbofan] Correctly call ArrayNoArgumentConstructor stub from TF code (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-generic-lowering.cc

diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc

index f9d456b106994bae5582c0df88d3c20aa23e528e..63b3e3941d77cdff21c0977f229e6a8282446bb1 100644

--- a/src/compiler/js-generic-lowering.cc

+++ b/src/compiler/js-generic-lowering.cc

@@ -441,7 +441,8 @@ void JSGenericLowering::LowerJSCreateArray(Node* node) {

CallDescriptor::kNeedsFrameState);

node->ReplaceInput(0, jsgraph()->HeapConstant(stub.GetCode()));

node->InsertInput(graph()->zone(), 2, jsgraph()->HeapConstant(site));

- node->InsertInput(graph()->zone(), 3, jsgraph()->UndefinedConstant());

+ node->InsertInput(graph()->zone(), 3, jsgraph()->Int32Constant(0));

+ node->InsertInput(graph()->zone(), 4, jsgraph()->UndefinedConstant());

NodeProperties::ChangeOp(node, common()->Call(desc));

} else if (arity == 1) {

// TODO(bmeurer): Optimize for the 0 length non-holey case?

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-612412.js » ('j') | test/mjsunit/regress/regress-612412.js » ('J')