Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1999783004: [turbofan] Correctly call ArrayNoArgumentConstructor stub from TF code (Closed)

Created:
4 years, 7 months ago by danno
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Correctly call ArrayNoArgumentConstructor stub from TF code BUG=chromium:612412 LOG=N Committed: https://crrev.com/f43aa0bc6c38d23717b09bd0339f95e5a6afae5b Cr-Commit-Position: refs/heads/master@{#36448}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-612412.js View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
danno
PTAL
4 years, 7 months ago (2016-05-21 09:11:53 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1999783004/diff/1/test/mjsunit/regress/regress-612412.js File test/mjsunit/regress/regress-612412.js (right): https://codereview.chromium.org/1999783004/diff/1/test/mjsunit/regress/regress-612412.js#newcode11 test/mjsunit/regress/regress-612412.js:11: for (var x = 0 ; x < 100000; ...
4 years, 7 months ago (2016-05-23 13:15:33 UTC) #3
danno
Feedback addressed
4 years, 7 months ago (2016-05-23 14:45:47 UTC) #4
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-23 14:46:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999783004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999783004/20001
4 years, 7 months ago (2016-05-23 16:41:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 16:43:03 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 16:44:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f43aa0bc6c38d23717b09bd0339f95e5a6afae5b
Cr-Commit-Position: refs/heads/master@{#36448}

Powered by Google App Engine
This is Rietveld 408576698