Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3389)

Unified Diff: cc/layers/solid_color_scrollbar_layer.cc

Issue 1999783003: cc : Initialize solid color scrollbar layer on main thread to 0. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/solid_color_scrollbar_layer.h ('k') | cc/layers/solid_color_scrollbar_layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/solid_color_scrollbar_layer.cc
diff --git a/cc/layers/solid_color_scrollbar_layer.cc b/cc/layers/solid_color_scrollbar_layer.cc
index 131e7735cb194a310363397636227267125f9cb7..9e4c65fd6512ca0085494aa851ce08c66cb31b6e 100644
--- a/cc/layers/solid_color_scrollbar_layer.cc
+++ b/cc/layers/solid_color_scrollbar_layer.cc
@@ -46,7 +46,9 @@ SolidColorScrollbarLayer::SolidColorScrollbarLayer(
orientation_(orientation),
thumb_thickness_(thumb_thickness),
track_start_(track_start),
- is_left_side_vertical_scrollbar_(is_left_side_vertical_scrollbar) {}
+ is_left_side_vertical_scrollbar_(is_left_side_vertical_scrollbar) {
+ Layer::SetOpacity(0.f);
+}
SolidColorScrollbarLayer::~SolidColorScrollbarLayer() {}
@@ -54,6 +56,12 @@ ScrollbarLayerInterface* SolidColorScrollbarLayer::ToScrollbarLayer() {
return this;
}
+void SolidColorScrollbarLayer::SetOpacity(float opacity) {
+ // The opacity of a solid color scrollbar layer is always 0 on main thread.
+ DCHECK_EQ(opacity, 0.f);
jaydasika 2016/05/24 23:37:23 I am not sure if we should still be overriding thi
+ Layer::SetOpacity(opacity);
+}
+
void SolidColorScrollbarLayer::PushPropertiesTo(LayerImpl* layer) {
Layer::PushPropertiesTo(layer);
SolidColorScrollbarLayerImpl* scrollbar_layer =
« no previous file with comments | « cc/layers/solid_color_scrollbar_layer.h ('k') | cc/layers/solid_color_scrollbar_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698