views::Textfield: Implement transpose editing command.

ui/views/cocoa/bridged_native_widget_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_native_widget.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 
@@ skipping 94 matching lines @@
   @"moveToLeftEndOfLineAndModifySelection:",
   @"moveToRightEndOfLineAndModifySelection:"
 ];
 
 NSArray* const kDeleteActions = @[
   @"deleteForward:", @"deleteBackward:", @"deleteWordForward:",
   @"deleteWordBackward:", @"deleteToBeginningOfLine:", @"deleteToEndOfLine:",
   @"deleteToBeginningOfParagraph:", @"deleteToEndOfParagraph:"
 ];
 
-NSArray* const kMiscActions = @[ @"insertText:", @"cancelOperation:" ];
+NSArray* const kMiscActions =
+    @[ @"insertText:", @"cancelOperation:", @"transpose:" ];
 
 // Empty range shortcut for readibility.
 NSRange EmptyRange() {
   return NSMakeRange(NSNotFound, 0);
 }
 
 // Sets |composition_text| as the composition text with caret placed at
 // |caret_pos| and updates |caret_range|.
 void SetCompositionText(ui::TextInputClient* client,
                         const base::string16& composition_text,
@@ skipping 228 matching lines @@
   view_->AddChildView(textfield);
   textfield->SetBoundsRect(init_params_.bounds);
 
   // Request focus so the InputMethod can dispatch events to the RootView, and
   // have them delivered to the textfield. Note that focusing a textfield
   // schedules a task to flash the cursor, so this requires |message_loop_|.
   textfield->RequestFocus();
 
   [ns_view_ setTextInputClient:textfield];
 
-  // Initialize the dummy text view.
-  dummy_text_view_.reset([[NSTextView alloc] initWithFrame:NSZeroRect]);
+  // Initialize the dummy text view. Initializing this with NSZeroRect causes
+  // weird NSTextView behavior on OSX 10.9.
+  dummy_text_view_.reset(
+      [[NSTextView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100)]);

[tapted, 2016/06/29 07:06:14]

probs need to rebase this bit

[karandeepb, 2016/06/29 07:33:45]

Done.

   [dummy_text_view_ setString:SysUTF16ToNSString(text)];
 }
 
 void BridgedNativeWidgetTest::InstallTextField(const base::string16& text) {
   InstallTextField(text, ui::TEXT_INPUT_TYPE_TEXT);
 }
 
 void BridgedNativeWidgetTest::InstallTextField(const std::string& text) {
   InstallTextField(base::ASCIIToUTF16(text), ui::TEXT_INPUT_TYPE_TEXT);
 }
@@ skipping 618 matching lines @@
 TEST_F(BridgedNativeWidgetTest, TextInput_DeleteToBeginningOfParagraph) {
   TestDeleteBeginning(@selector(deleteToBeginningOfParagraph:));
 }
 
 TEST_F(BridgedNativeWidgetTest, TextInput_DeleteToEndOfParagraph) {
   TestDeleteEnd(@selector(deleteToEndOfParagraph:));
 }
 
 // Test move commands against expectations set by |dummy_text_view_|.
 TEST_F(BridgedNativeWidgetTest, TextInput_MoveEditingCommands) {
-  // Broken on 10.9. http://crbug.com/621734.
-  if (base::mac::IsOSMavericks())
-    return;
   TestEditingCommands(kMoveActions);
 }
 
 // Todo(karandeepb): Enable this test once the behavior of all move and select
 // commands are fixed.
 // Test move and select commands against expectations set by |dummy_text_view_|.
 TEST_F(BridgedNativeWidgetTest,
        TextInput_MoveAndSelectEditingCommands_DISABLED) {
   TestEditingCommands(kSelectActions);
 }
 
 // Test delete commands against expectations set by |dummy_text_view_|.
 TEST_F(BridgedNativeWidgetTest, TextInput_DeleteCommands) {
-  // Broken on 10.9. http://crbug.com/621734.
-  if (base::mac::IsOSMavericks())
-    return;
   TestEditingCommands(kDeleteActions);
 }
 
 // Test that we don't crash during an action message even if the TextInputClient
 // is nil. Regression test for crbug.com/615745.
 TEST_F(BridgedNativeWidgetTest, NilTextInputClient) {
   [ns_view_ setTextInputClient:nil];
   NSMutableArray* selectors = [NSMutableArray array];
   [selectors addObjectsFromArray:kMoveActions];
   [selectors addObjectsFromArray:kSelectActions];
   [selectors addObjectsFromArray:kDeleteActions];
   [selectors addObjectsFromArray:kMiscActions];
 
   for (NSString* selector in selectors)
     [ns_view_ doCommandBySelector:NSSelectorFromString(selector)];
 }
 
+// Test transpose command against expectations set by |dummy_text_view_|.
+TEST_F(BridgedNativeWidgetTest, TextInput_Transpose) {
+  TestEditingCommands(@[ @"transpose:" ]);
+}
+
 // Test firstRectForCharacterRange:actualRange for cases where query range is
 // empty or outside composition range.
 TEST_F(BridgedNativeWidgetTest, TextInput_FirstRectForCharacterRange_Caret) {
   InstallTextField("");
   ui::TextInputClient* client = [ns_view_ textInputClient];
 
   // No composition. Ensure bounds and range corresponding to the current caret
   // position are returned.
   // Initially selection range will be [0, 0].
   NSRange caret_range = NSMakeRange(0, 0);
@@ skipping 144 matching lines @@
   [center postNotificationName:NSWindowDidExitFullScreenNotification
                         object:window];
   EXPECT_EQ(1, [window ignoredToggleFullScreenCount]);  // No change.
   EXPECT_FALSE(bridge()->target_fullscreen_state());
 
   widget_->CloseNow();
 }
 
 }  // namespace test
 }  // namespace views