views::Textfield: Implement transpose editing command.

ui/views/controls/textfield/textfield_model.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield_model.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 509 matching lines @@
 
   base::string16 actual_text = base::CollapseWhitespace(text, false);
   // If the clipboard contains all whitespaces then paste a single space.
   if (actual_text.empty())
     actual_text = base::ASCIIToUTF16(" ");
 
   InsertTextInternal(actual_text, false);
   return true;
 }
 
+bool TextfieldModel::Transpose() {
+  if (HasCompositionText() || HasSelection())
+    return false;
+
+  size_t cur = GetCursorPosition();
+  size_t next = render_text_->IndexOfAdjacentGrapheme(cur, gfx::CURSOR_FORWARD);
+  size_t prev =
+      render_text_->IndexOfAdjacentGrapheme(cur, gfx::CURSOR_BACKWARD);
+
+  // If we are at the end of the line, last two characters should be transposed.

[tapted, 2016/06/28 04:52:32]

nit: "If we are at .. line, last" -> "At .. line, the last"

[karandeepb, 2016/06/29 05:44:37]

Done.

+  if (cur == text().length()) {
+    DCHECK_EQ(cur, next);
+    cur = prev;
+    prev = render_text_->IndexOfAdjacentGrapheme(prev, gfx::CURSOR_BACKWARD);
+  }
+
+  // This happens when we are at the beginning of the line or the line has less

[tapted, 2016/06/28 04:52:32]

nit: remove "when we are", add `when` in "..line or when the line.."

[karandeepb, 2016/06/29 05:44:37]

Done.

+  // than two graphemes.
+  if (gfx::UTF16IndexToOffset(text(), prev, next) != 2)
+    return false;
+
+  SelectRange(gfx::Range(prev, next));
+  base::string16 text = GetSelectedText();
+  base::string16 transposed_text =
+      text.substr(cur - prev) + text.substr(0, cur - prev);

[tapted, 2016/06/28 04:52:32]

Should we add some emoji/surrogate pairs to
BridgedNativeWidgetTest::TestEditingCommands ?

[karandeepb, 2016/06/29 05:44:37]

Tried this but there are a few minor differences between how Views and
NSTextView handle emojis. For example for a string like 😊😎 NSTextView doesn't
transpose if we are at the end of the string. (probably an NSTextView bug). 
If at the string beginning and we do Alt+right (moveWordRight:),
Views::Textfield moves past both emojis while NSTextView moves past only the
first emoji.

[tapted, 2016/06/29 07:06:14]

Acknowledged.

+
+  InsertTextInternal(transposed_text, false);
+  return true;
+}

[tapted, 2016/06/28 04:52:32]

do you need to do anything special to get `undo` to work? Maybe that's another
good thing to include in BridgedNativeWidgetTest::TestEditingCommands -- i.e.
after PerformCommand, PerformCommand(@selector(undo:)) and see if they text and
selection matches.  (I suspect the selection currently will not..)

[karandeepb, 2016/06/29 05:44:37]

Undo behavior is not completely correct currently, not just for MacViews but
also on other platforms. I had filed a bug for this - http://crbug.com/615345
and plan to take it on later.

Regarding adding undo verification to
BridgedNativeWidgetTest::TestEditingCommands, it seems that action messages
performed using doCommandBySelector are not added to the undo stack for the
NSTextView. Will have to investigate how to get undo to work for these
programmatic NSTextView modifications, but that can probably wait till the undo
fix.

[tapted, 2016/06/29 07:06:14]

Acknowledged.

+
 bool TextfieldModel::HasSelection() const {
   return !render_text_->selection().is_empty();
 }
 
 void TextfieldModel::DeleteSelection() {
   DCHECK(!HasCompositionText());
   DCHECK(HasSelection());
   ExecuteAndRecordDelete(render_text_->selection(), false);
 }
 
@@ skipping 234 matching lines @@
   ClearComposition();
   if (delete_from != delete_to)
     render_text_->SetText(old_text.erase(delete_from, delete_to - delete_from));
   if (!new_text.empty())
     render_text_->SetText(old_text.insert(new_text_insert_at, new_text));
   render_text_->SetCursorPosition(new_cursor_pos);
   // TODO(oshima): Select text that was just undone, like Mac (but not GTK).
 }
 
 }  // namespace views