Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1999753002: [heap] Harden heap-related cctests (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Harden heap-related cctests - Move usable functions into proper heap-utils.h/.cc files and remove utils-inl.h file - Fix assumptions accross the board relying on certain behavior that is not invariant This is a requirement for modifying page size. BUG=chromium:581412 LOG=N R=ulan@chromium.org Committed: https://crrev.com/fdd9f6b92d869e5b7222fb734337a0d4e72df269 Cr-Commit-Position: refs/heads/master@{#36410}

Patch Set 1 #

Patch Set 2 : Fix crashing tests #

Patch Set 3 : Fix for win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -370 lines) Patch
M src/heap/gc-tracer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/heap/spaces-inl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +2 lines, -1 line 0 comments Download
A test/cctest/heap/heap-utils.h View 1 chunk +47 lines, -0 lines 0 comments Download
A + test/cctest/heap/heap-utils.cc View 1 5 chunks +53 lines, -55 lines 0 comments Download
M test/cctest/heap/test-alloc.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/heap/test-compaction.cc View 15 chunks +40 lines, -32 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 47 chunks +64 lines, -53 lines 0 comments Download
M test/cctest/heap/test-incremental-marking.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/heap/test-mark-compact.cc View 1 2 chunks +31 lines, -41 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
D test/cctest/heap/utils-inl.h View 1 chunk +0 lines, -148 lines 0 comments Download
M test/cctest/test-api.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-dictionary.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-slots-buffer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-weaksets.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael Lippautz
ptal
4 years, 7 months ago (2016-05-20 11:21:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999753002/20001
4 years, 7 months ago (2016-05-20 12:06:13 UTC) #5
ulan
lgtm!
4 years, 7 months ago (2016-05-20 12:58:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999753002/40001
4 years, 7 months ago (2016-05-20 12:58:15 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-20 13:30:27 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 13:32:55 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fdd9f6b92d869e5b7222fb734337a0d4e72df269
Cr-Commit-Position: refs/heads/master@{#36410}

Powered by Google App Engine
This is Rietveld 408576698