Continued fix for 351257. Reusing the feedback vector is too complex.

Continued fix for 351257. Reusing the feedback vector is too complex.

Attempting to re-use the type feedback vector stored in the
SharedFunctionInfo turns out to be difficult among the various cases.
It will be much easier to do this when deferred type feedback processing
is removed, as is in the works.

Created bug v8:3212 to track re-introducing the optimization of reusing
the type vector on recompile before optimization.

The CL also brings back the type vector on the SharedFunctionInfo.

BUG=351257
LOG=Y
R=bmeurer@chromium.org, bmeuer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19919

[mvstanton, 2014-03-14 09:15:03]

Hi Benedikt, PTAL, thx,
--Michael

[Benedikt Meurer, 2014-03-14 09:22:08]

LGTM with nit (and it should be LOG=y).

https://codereview.chromium.org/199973004/diff/20001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/199973004/diff/20001/src/compiler.cc#newcode259
src/compiler.cc:259: feedback_vector_->set(i,
Nit: funky indentation.

[mvstanton, 2014-03-14 09:28:55]

Committed patchset #2 manually as r19919 (presubmit successful).

[Toon Verwaest, 2014-03-16 16:13:34]

I believe this change has tanked Octane.