Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: appengine/findit/templates/config.html

Issue 1999653003: [Findit] Bailing out if build data is too old and moving relevant settings to config (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/model/wf_config.py ('k') | appengine/findit/waterfall/build_util.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <head> 2 <head>
3 <meta charset="utf-8"> 3 <meta charset="utf-8">
4 <script src="//ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></sc ript> 4 <script src="//ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></sc ript>
5 <link rel="stylesheet" href="/common.css"></link> 5 <link rel="stylesheet" href="/common.css"></link>
6 <title>Findit Configuration</title> 6 <title>Findit Configuration</title>
7 <style> 7 <style>
8 .previous, .next, .latest { 8 .previous, .next, .latest {
9 color: #0645AD; 9 color: #0645AD;
10 background:none!important; 10 background:none!important;
(...skipping 12 matching lines...) Expand all
23 border-bottom:1px solid #d3d3d3; 23 border-bottom:1px solid #d3d3d3;
24 cursor: pointer; 24 cursor: pointer;
25 } 25 }
26 </style> 26 </style>
27 <script> 27 <script>
28 var findit = {}; 28 var findit = {};
29 findit.stepsForMastersRules = {{ masters | tojson | safe }}; 29 findit.stepsForMastersRules = {{ masters | tojson | safe }};
30 findit.builders = {{ builders | tojson | safe }}; 30 findit.builders = {{ builders | tojson | safe }};
31 findit.tryJobSettings = {{ try_job_settings | tojson | safe}}; 31 findit.tryJobSettings = {{ try_job_settings | tojson | safe}};
32 findit.swarmingSettings = {{ swarming_settings | tojson | safe }}; 32 findit.swarmingSettings = {{ swarming_settings | tojson | safe }};
33 findit.downloadBuildDataSettings = {{ download_build_data_settings | tojson | safe }}
33 34
34 function getJsonOfTextarea(textId) { 35 function getJsonOfTextarea(textId) {
35 return JSON.parse($('#' + textId).val()); 36 return JSON.parse($('#' + textId).val());
36 } 37 }
37 38
38 function getStringFromJson(json) { 39 function getStringFromJson(json) {
39 return JSON.stringify(json, null, ' '); 40 return JSON.stringify(json, null, ' ');
40 } 41 }
41 42
42 function createUrl(version) { 43 function createUrl(version) {
(...skipping 16 matching lines...) Expand all
59 function loadLatest() { 60 function loadLatest() {
60 var newUrl = createUrl(null); 61 var newUrl = createUrl(null);
61 window.location.replace(newUrl); 62 window.location.replace(newUrl);
62 } 63 }
63 64
64 function save(e) { 65 function save(e) {
65 var newConfig = { 66 var newConfig = {
66 'steps_for_masters_rules': getJsonOfTextarea('steps-for-masters-rules'), 67 'steps_for_masters_rules': getJsonOfTextarea('steps-for-masters-rules'),
67 'builders_to_trybots': getJsonOfTextarea('builders-to-trybots'), 68 'builders_to_trybots': getJsonOfTextarea('builders-to-trybots'),
68 'try_job_settings': getJsonOfTextarea('try-job-settings'), 69 'try_job_settings': getJsonOfTextarea('try-job-settings'),
69 'swarming_settings': getJsonOfTextarea('swarming-settings') 70 'swarming_settings': getJsonOfTextarea('swarming-settings'),
71 'download_build_data_settings': getJsonOfTextarea('download-build-data-s ettings')
70 }; 72 };
71 $.post('/waterfall/config', { data: JSON.stringify(newConfig) }).done(func tion(){ 73 $.post('/waterfall/config', { data: JSON.stringify(newConfig) }).done(func tion(){
72 window.location.replace(createUrl(null)); // Reload after successful sa ving. 74 window.location.replace(createUrl(null)); // Reload after successful sa ving.
73 }).fail(function(xhr){ 75 }).fail(function(xhr){
74 // Replace the whole page with errors from server side. 76 // Replace the whole page with errors from server side.
75 document.body.outerHTML = xhr.responseText; 77 document.body.outerHTML = xhr.responseText;
76 }); 78 });
77 e.preventDefault(); 79 e.preventDefault();
78 } 80 }
79 81
80 $(document).ready(function() { 82 $(document).ready(function() {
81 $('#previous-version-button').click(loadPrevious); 83 $('#previous-version-button').click(loadPrevious);
82 $('#next-version-button').click(loadNext); 84 $('#next-version-button').click(loadNext);
83 $('#latest-version-button').click(loadLatest); 85 $('#latest-version-button').click(loadLatest);
84 $('#save-button').click(save); 86 $('#save-button').click(save);
85 $('#steps-for-masters-rules').val(getStringFromJson(findit.stepsForMasters Rules)); 87 $('#steps-for-masters-rules').val(getStringFromJson(findit.stepsForMasters Rules));
86 $('#builders-to-trybots').val(getStringFromJson(findit.builders)); 88 $('#builders-to-trybots').val(getStringFromJson(findit.builders));
87 $('#try-job-settings').val(getStringFromJson(findit.tryJobSettings)); 89 $('#try-job-settings').val(getStringFromJson(findit.tryJobSettings));
88 $('#swarming-settings').val(getStringFromJson(findit.swarmingSettings)); 90 $('#swarming-settings').val(getStringFromJson(findit.swarmingSettings));
91 $('#download-build-data-settings').val(getStringFromJson(findit.downloadBu ildDataSettings));
89 92
90 if ({{ version }} < 2) { 93 if ({{ version }} < 2) {
91 $('#previous-version-button').attr('disabled', 'disabled'); 94 $('#previous-version-button').attr('disabled', 'disabled');
92 $('#previous-version-button').addClass('disabled'); 95 $('#previous-version-button').addClass('disabled');
93 } 96 }
94 else if ({{ version }} >= {{ latest_version }} ) { 97 else if ({{ version }} >= {{ latest_version }} ) {
95 $('#next-version-button').attr('disabled', 'disabled'); 98 $('#next-version-button').attr('disabled', 'disabled');
96 $('#next-version-button').addClass('disabled'); 99 $('#next-version-button').addClass('disabled');
97 } 100 }
98 else { 101 else {
(...skipping 26 matching lines...) Expand all
125 <textarea id="builders-to-trybots" rows="20" cols="80"></textarea> 128 <textarea id="builders-to-trybots" rows="20" cols="80"></textarea>
126 </div> 129 </div>
127 <div> 130 <div>
128 Try Job Settings:<br> 131 Try Job Settings:<br>
129 <textarea id="try-job-settings" rows="10" cols="80"></textarea> 132 <textarea id="try-job-settings" rows="10" cols="80"></textarea>
130 </div> 133 </div>
131 <div> 134 <div>
132 Swarming Task Settings:<br> 135 Swarming Task Settings:<br>
133 <textarea id="swarming-settings" rows="10" cols="80"></textarea> 136 <textarea id="swarming-settings" rows="10" cols="80"></textarea>
134 </div> 137 </div>
138 <div>
139 Download Build Data Settings:<br>
140 <textarea id="download-build-data-settings" rows="10" cols="80"></textarea>
141 </div>
135 <br> 142 <br>
136 <button type="submit" id="save-button">Save</button> 143 <button type="submit" id="save-button">Save</button>
137 </body> 144 </body>
OLDNEW
« no previous file with comments | « appengine/findit/model/wf_config.py ('k') | appengine/findit/waterfall/build_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698