[Findit] Bailing out if build data is too old and moving relevant settings to config

appengine/findit/handlers/test/config_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import re
 import webapp2
 import webtest
 
@@ skipping 50 matching lines @@
     'server_host': 'chromium-swarm.appspot.com',
     'default_request_priority': 150,
     'request_expiration_hours': 20,
     'server_query_interval_seconds': 60,
     'task_timeout_hours': 23,
     'isolated_server': 'https://isolateserver.appspot.com',
     'isolated_storage_url': 'isolateserver.storage.googleapis.com',
     'iterations_to_rerun': 10
 }
 
+
+_MOCK_DOWNLOAD_BUILD_DATA_SETTINGS = {
+    'download_interval_seconds': 10,
+    'memcache_master_download_expiration_seconds': 3600,
+    'use_chrome_build_extract': True
+}
+
 _MOCK_VERSION_NUMBER = 12
 
 
 class ConfigTest(testing.AppengineTestCase):
   app_module = webapp2.WSGIApplication([
       ('/config', config.Configuration),
   ], debug=True)
 
   def testGetConfigurationSettings(self):
     config_data = {
         'steps_for_masters_rules': _MOCK_STEPS_FOR_MASTERS_RULES,
         'builders_to_trybots': _MOCK_BUILDERS_TO_TRYBOTS,
         'try_job_settings': _MOCK_TRY_JOB_SETTINGS,
-        'swarming_settings': _MOCK_SWARMING_SETTINGS
+        'swarming_settings': _MOCK_SWARMING_SETTINGS,
+        'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS
     }
 
     self.mock_current_user(user_email='test@chromium.org', is_admin=True)
 
     wf_config.FinditConfig.Get().Update(users.GetCurrentUser(), True,
                                         **config_data)
 
     response = self.test_app.get('/config', params={'format': 'json'})
     self.assertEquals(response.status_int, 200)
 
     expected_response = {
         'masters': _MOCK_STEPS_FOR_MASTERS_RULES,
         'builders': _MOCK_BUILDERS_TO_TRYBOTS,
         'try_job_settings': _MOCK_TRY_JOB_SETTINGS,
         'swarming_settings': _MOCK_SWARMING_SETTINGS,
+        'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS,
         'version': 1,
         'latest_version': 1,
         'updated_by': 'test',
         'updated_ts': response.json_body.get('updated_ts')
     }
 
     self.assertEquals(expected_response, response.json_body)
 
   def testGetVersionOfConfigurationSettings(self):
     self.mock_current_user(user_email='test@chromium.org', is_admin=True)
 
     config_data = {
         'steps_for_masters_rules': _MOCK_STEPS_FOR_MASTERS_RULES,
         'builders_to_trybots': _MOCK_BUILDERS_TO_TRYBOTS,
         'try_job_settings': _MOCK_TRY_JOB_SETTINGS,
-        'swarming_settings': _MOCK_SWARMING_SETTINGS
+        'swarming_settings': _MOCK_SWARMING_SETTINGS,
+        'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS
     }
     wf_config.FinditConfig.Get().Update(users.GetCurrentUser(), True,
                                         **config_data)
 
     response = self.test_app.get(
         '/config', params={'version': 1, 'format': 'json'})
     self.assertEquals(response.status_int, 200)
 
     expected_response = {
         'masters': _MOCK_STEPS_FOR_MASTERS_RULES,
         'builders': _MOCK_BUILDERS_TO_TRYBOTS,
         'try_job_settings': _MOCK_TRY_JOB_SETTINGS,
         'swarming_settings': _MOCK_SWARMING_SETTINGS,
+        'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS,
         'version': 1,
         'latest_version': 1,
         'updated_by': 'test',
         'updated_ts': response.json_body.get('updated_ts')
     }
 
     self.assertEquals(expected_response, response.json_body)
 
   def testGetOutOfBoundsVersionOfConfigurationSettings(self):
     config_data = {
@@ skipping 409 matching lines @@
         'server_host': 'chromium-swarm.appspot.com',
         'default_request_priority': 150,
         'request_expiration_hours': 20,
         'server_query_interval_seconds': 60,
         'task_timeout_hours': 23,
         'isolated_server': 'https://isolateserver.appspot.com',
         'isolated_storage_url': 'isolateserver.storage.googleapis.com',
         'iterations_to_rerun': 10
     }))
 
+  def testValidateDownloadBuildDataSettings(self):
+    self.assertFalse(config._ValidateDownloadBuildDataSettings({}))
+    self.assertFalse(config._ValidateDownloadBuildDataSettings({
+        'download_interval_seconds': {},  # Should be an int.
+        'memcache_master_download_expiration_seconds': 10,
+        'use_chrome_build_extract': True
+        }))
+    self.assertFalse(config._ValidateDownloadBuildDataSettings({
+        'download_interval_seconds': 10,
+        'memcache_master_download_expiration_seconds': [],  # Should be an int.
+        'use_chrome_build_extract': True
+        }))
+    self.assertFalse(config._ValidateDownloadBuildDataSettings({
+        'download_interval_seconds': 10,
+        'memcache_master_download_expiration_seconds': 3600,
+        'use_chrome_build_extract': 'blabla'  # Should be a bool.
+        }))
+    self.assertTrue(config._ValidateDownloadBuildDataSettings({
+        'download_interval_seconds': 10,
+        'memcache_master_download_expiration_seconds': 3600,
+        'use_chrome_build_extract': False
+        }))
+
   def testConfigurationDictIsValid(self):
     self.assertTrue(config._ConfigurationDictIsValid({
         'steps_for_masters_rules': {
             'supported_masters': {
                 'master1': {
                     'unsupported_steps': ['step1', 'step2'],
                 },
                 'master2': {
                     'supported_steps': ['step3'],
                     'check_global': False
@@ skipping 33 matching lines @@
                         'supported_steps': ['5'],
                         'check_global': False
                     }
                 },
                 'global': {
                     'unsupported_steps': ['1']
                 }
             },
             'builders_to_trybots': _MOCK_BUILDERS_TO_TRYBOTS,
             'try_job_settings': _MOCK_TRY_JOB_SETTINGS,
-            'swarming_settings': _MOCK_SWARMING_SETTINGS
+            'swarming_settings': _MOCK_SWARMING_SETTINGS,
+            'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS
         })
     }
 
     response = self.test_app.post('/config', params=params)
 
     expected_response = {
         'masters': {
             'supported_masters': {
                 'a': {
                 },
                 'b': {
                     'supported_steps': ['1'],
                     'unsupported_steps': ['2', '3', '4'],
                 },
                 'c': {
                     'supported_steps': ['5'],
                     'check_global': False
                 }
             },
             'global': {
                 'unsupported_steps': ['1']
             }
         },
         'builders': _MOCK_BUILDERS_TO_TRYBOTS,
         'try_job_settings': _MOCK_TRY_JOB_SETTINGS,
         'swarming_settings': _MOCK_SWARMING_SETTINGS,
+        'download_build_data_settings': _MOCK_DOWNLOAD_BUILD_DATA_SETTINGS,
         'version': 1,
         'latest_version': 1,
         'updated_by': 'test',
         'updated_ts': response.json_body.get('updated_ts')
     }
 
     self.assertEquals(expected_response, response.json_body)