[Findit] Bailing out if build data is too old and moving relevant settings to config

appengine/findit/handlers/config.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Handles requests to the findit config page."""
 
 import json
 
 from common.base_handler import BaseHandler
 from common.base_handler import Permission
@@ skipping 148 matching lines @@
           isinstance(settings.get('server_host'), basestring) and
           isinstance(settings.get('default_request_priority'), int) and
           isinstance(settings.get('request_expiration_hours'), int) and
           isinstance(settings.get('server_query_interval_seconds'), int) and
           isinstance(settings.get('task_timeout_hours'), int) and
           isinstance(settings.get('isolated_server'), basestring) and
           isinstance(settings.get('isolated_storage_url'), basestring) and
           isinstance(settings.get('iterations_to_rerun'), int))
 
 
+def _ValidateDownloadBuildDataSettings(settings):
+  return (isinstance(settings, dict) and
+          isinstance(settings.get('download_interval_seconds'), int) and
+          isinstance(settings.get(
+              'memcache_master_download_expiration_seconds'), int) and
+          isinstance(settings.get('use_chrome_build_extract'), bool))
+
+
 # Maps config properties to their validation functions.
 _CONFIG_VALIDATION_FUNCTIONS = {
     'steps_for_masters_rules': _ValidateMastersAndStepsRulesMapping,
     'builders_to_trybots': _ValidateTrybotMapping,
     'try_job_settings': _ValidateTryJobSettings,
-    'swarming_settings': _ValidateSwarmingSettings
+    'swarming_settings': _ValidateSwarmingSettings,
+    'download_build_data_settings': _ValidateDownloadBuildDataSettings
 }
 
 
 def _ConfigurationDictIsValid(configuration_dict):
   """Checks that each configuration setting is properly formatted.
 
   Args:
       configuration_dict: A dictionary expected to map configuration properties
       by name to their intended settings. For example,
 
@@ skipping 41 matching lines @@
       return self.CreateError(
           'The requested version is invalid or not found.', 400)
 
     latest_version = settings.GetLatestVersionNumber()
 
     data = {
         'masters': waterfall_config.GetStepsForMastersRules(settings),
         'builders': settings.builders_to_trybots,
         'try_job_settings': settings.try_job_settings,
         'swarming_settings': settings.swarming_settings,
+        'download_build_data_settings': settings.download_build_data_settings,
         'version': settings.version,
         'latest_version': latest_version,
         'updated_by': settings.updated_by,
         'updated_ts': _FormatTimestamp(settings.updated_ts)
     }
 
     return {'template': 'config.html', 'data': data}
 
   def HandlePost(self):
     data = self.request.params.get('data')
     new_config_dict = json.loads(data)
     if not _ConfigurationDictIsValid(new_config_dict):  # pragma: no cover
       return self.CreateError(
           'New configuration settings is not properly formatted.', 400)
 
     wf_config.FinditConfig.Get().Update(users.get_current_user(),
                                         users.IsCurrentUserAdmin(),
                                         **new_config_dict)
 
     return self.HandleGet()