[Findit] Bailing out if build data is too old and moving relevant settings to config

appengine/findit/waterfall/try_job_util.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+from datetime import datetime
 import logging
 
 from google.appengine.ext import ndb
 
 from common import appengine_util
 from common import constants
 from common.waterfall import failure_type
 from model import analysis_status
+from model.wf_build import WfBuild
 from model.wf_try_job import WfTryJob
 from waterfall import swarming_tasks_to_try_job_pipeline
 from waterfall import waterfall_config
 from waterfall.try_job_type import TryJobType
 
 
 def _CheckFailureForTryJobKey(
     master_name, builder_name, build_number,
     failure_result_map, failed_step_or_test, failure):
   """Compares the current_failure and first_failure for each failed_step/test.
@@ skipping 122 matching lines @@
   return list(suspected_revisions)
 
 
 def ScheduleTryJobIfNeeded(failure_info, signals, heuristic_result):
   master_name = failure_info['master_name']
   builder_name = failure_info['builder_name']
   build_number = failure_info['build_number']
   failed_steps = failure_info.get('failed_steps', [])
   builds = failure_info.get('builds', {})
 
+  # Bail out if the build data's timestamp is more than 24 hours old to
+  # avoid using outdated revisions. TODO(lijeffrey): This will also disallow
+  # manually triggering try jobs more than a day old using build_completed=1.
+  # Need to implement a flag to force try jobs regardless of timestamp.
+  build = WfBuild.Get(master_name, builder_name, build_number)
+  if (datetime.utcnow() - build.start_time).days > 0:

[stgao, 2016/05/21 04:26:41]

Move the check to a separate function, and it could be mocked in the test.

[lijeffrey, 2016/05/21 09:02:52]

Done.

+    logging.error(
+        'Build time is more than 24 hours old. Try job will not be triggered.')
+    return {}
+
   tryserver_mastername, tryserver_buildername = (
       waterfall_config.GetTrybotForWaterfallBuilder(master_name, builder_name))
 
   if not tryserver_mastername or not tryserver_buildername:
     logging.info('%s, %s is not supported yet.', master_name, builder_name)
     return {}
   elif (failure_info['failure_type'] == failure_type.TEST and
         waterfall_config.ShouldSkipTestTryJobs(master_name, builder_name)):
     logging.info('Test try jobs on %s, %s are not supported yet.',
                  master_name, builder_name)
@@ skipping 31 matching lines @@
               pipeline.pipeline_status_path, try_job_type)
     else:  # pragma: no cover
       logging_str = (
           'Try job was scheduled for build %s, %s, %s: %s because of %s '
           'failure.') % (
               master_name, builder_name, build_number,
               pipeline.pipeline_status_path, try_job_type)
     logging.info(logging_str)
 
   return failure_result_map