[Findit] Bailing out if build data is too old and moving relevant settings to config

appengine/findit/waterfall/test/try_job_util_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+from datetime import datetime
+from datetime import timedelta
+
 from common.waterfall import failure_type
 from model import analysis_status
+from model.wf_build import WfBuild
 from model.wf_try_job import WfTryJob
 from waterfall import try_job_util
 from waterfall.test import wf_testcase
 from waterfall.try_job_type import TryJobType
 
 
 class _MockRootPipeline(object):
   STARTED = False
 
   def __init__(self, *_):
@@ skipping 42 matching lines @@
                 'chromium_revision': '223-3'
             }
         }
     }
 
     self.mock(
         try_job_util.swarming_tasks_to_try_job_pipeline,
         'SwarmingTasksToTryJobPipeline', _MockRootPipeline)
     _MockRootPipeline.STARTED = False
 
+    build = WfBuild.Create(master_name, builder_name, build_number)
+    build.start_time = datetime.utcnow()

[stgao, 2016/05/21 04:26:41]

This might make the test flaky as it depends on the OS clock.

See my comment below.

+    build.put()
+
     failure_result_map = try_job_util.ScheduleTryJobIfNeeded(
         failure_info, None, None)
 
     self.assertFalse(_MockRootPipeline.STARTED)
     self.assertEqual({}, failure_result_map)
 
   def testBailOutForTestTryJob(self):
     master_name = 'master2'
     builder_name = 'builder2'
     build_number = 223
     failure_info = {
         'master_name': master_name,
         'builder_name': builder_name,
         'build_number': build_number,
         'failed_steps': {
             'a_test': {}
         },
         'failure_type': failure_type.TEST
     }
 
+    build = WfBuild.Create(master_name, builder_name, build_number)
+    build.start_time = datetime.utcnow()
+    build.put()
+
     failure_result_map = try_job_util.ScheduleTryJobIfNeeded(
         failure_info, None, None)
 
     self.assertEqual({}, failure_result_map)
 
+  def testBailOutForTryJobWithOutdatedTimestamp(self):
+    master_name = 'master3'
+    builder_name = 'builder3'
+    build_number = 223
+    failure_info = {
+        'master_name': master_name,
+        'builder_name': builder_name,
+        'build_number': build_number,
+        'failed_steps': {
+            'compile': {
+                'current_failure': 221,
+                'first_failure': 221,
+                'last_pass': 220
+            }
+        },
+    }
+
+    self.mock(
+        try_job_util.swarming_tasks_to_try_job_pipeline,
+        'SwarmingTasksToTryJobPipeline', _MockRootPipeline)
+    _MockRootPipeline.STARTED = False
+
+    yesterday = datetime.utcnow() - timedelta(days=1)
+    build = WfBuild.Create(master_name, builder_name, build_number)
+    build.start_time = yesterday
+    build.put()
+
+    failure_result_map = try_job_util.ScheduleTryJobIfNeeded(
+        failure_info, None, None)
+
+    self.assertFalse(_MockRootPipeline.STARTED)
+    self.assertEqual({}, failure_result_map)
+
   def testNotNeedANewTryJobIfNotFirstTimeFailure(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 223
     failure_info = {
         'master_name': master_name,
         'builder_name': builder_name,
         'build_number': build_number,
         'failed_steps': {
             'compile': {
@@ skipping 21 matching lines @@
             }
         },
         'failure_type': failure_type.COMPILE
     }
 
     self.mock(
         try_job_util.swarming_tasks_to_try_job_pipeline,
         'SwarmingTasksToTryJobPipeline', _MockRootPipeline)
     _MockRootPipeline.STARTED = False
 
+    build = WfBuild.Create(master_name, builder_name, build_number)
+    build.start_time = datetime.utcnow()
+    build.put()
+
     try_job_util.ScheduleTryJobIfNeeded(failure_info, None, None)
 
     self.assertFalse(_MockRootPipeline.STARTED)
 
   def testNotNeedANewTryJobIfOneWithResultExists(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 223
     failed_steps = {
         'compile': {
@@ skipping 215 matching lines @@
             }
         },
         'failure_type': failure_type.COMPILE
     }
 
     self.mock(
         try_job_util.swarming_tasks_to_try_job_pipeline,
         'SwarmingTasksToTryJobPipeline', _MockRootPipeline)
     _MockRootPipeline.STARTED = False
 
+    build = WfBuild.Create(master_name, builder_name, build_number)
+    build.start_time = datetime.utcnow()
+    build.put()
+
     try_job_util.ScheduleTryJobIfNeeded(failure_info, None, None)
 
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
 
     self.assertTrue(_MockRootPipeline.STARTED)
     self.assertIsNotNone(try_job)
 
   def testUseFailedOutputNodesFromSignals(self):
     signals = {
         'compile': {
@@ skipping 88 matching lines @@
                         'revision': 'r3',
                     },
                 ],
             },
         ]
     }
     expected_suspected_revisions = ['r1', 'r2', 'r3']
     self.assertEqual(
         expected_suspected_revisions,
         try_job_util._GetSuspectsFromHeuristicResult(heuristic_result))