Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1999633002: Make json_schema_compiler generate only int-sized enums

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, sadrul, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make json_schema_compiler generate only int-sized enums This allows them to be forward-declared. BUG=611898

Patch Set 1 #

Patch Set 2 : Fix a few things. still crashes clang #

Patch Set 3 : more iwyu #

Patch Set 4 : mac compiles clean #

Patch Set 5 : Split IWYU stuff out to crrev/1996893002 #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -19 lines) Patch
M ash/accessibility_delegate.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/chrome_extension_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_event.h View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M content/public/browser/ax_event_notification_details.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.h View 1 2 3 4 5 1 chunk +12 lines, -1 line 0 comments Download
M tools/json_schema_compiler/h_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_node_data.h View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M ui/accessibility/ax_tree_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/ax_view_state.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.h View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M ui/views/view.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/views_delegate.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/widget_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/window/dialog_delegate.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (3 generated)
tapted
Description was changed from ========== Make json_schema_compiler generate only int-sized enums This allows them to ...
4 years, 7 months ago (2016-05-20 04:46:04 UTC) #1
tapted
Description was changed from ========== Make json_schema_compiler generate only int-sized enums This allows them to ...
4 years, 7 months ago (2016-05-20 05:48:03 UTC) #2
tapted
4 years, 7 months ago (2016-05-20 06:14:35 UTC) #3 
Description was changed from

==========
Make json_schema_compiler generate only int-sized enums

This allows them to be forward-declared.

BUG=612382
==========

to

==========
Make json_schema_compiler generate only int-sized enums

This allows them to be forward-declared.

BUG=611898
==========

Powered by Google App Engine
This is Rietveld 408576698