Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1999613002: Move WebCacheMemoryDumpProvider to platform (Closed)

Created:
4 years, 7 months ago by bashi
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebCacheMemoryDumpProvider to platform Also rename it as MemoryCacheDumpProvider and make it inherit from base::trace_event::MemoryDumpProvider directly. After this CL, no dumper inherits from WebMemoryDumpProvider so we can start removing it. BUG=605822 Committed: https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30 Cr-Commit-Position: refs/heads/master@{#395019}

Patch Set 1 #

Patch Set 2 : Fix link error on win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -91 lines) Patch
M third_party/WebKit/Source/core/CoreInitializer.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 6 chunks +5 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/WebCacheMemoryDumpProvider.h View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/WebCacheMemoryDumpProvider.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
A third_party/WebKit/Source/platform/MemoryCacheDumpProvider.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/MemoryCacheDumpProvider.cpp View 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bashi
PTAL? Might look not worth doing, but actual work comes after this CL...
4 years, 7 months ago (2016-05-20 03:24:30 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-20 03:43:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999613002/20001
4 years, 7 months ago (2016-05-20 04:24:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 06:32:57 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 06:35:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30
Cr-Commit-Position: refs/heads/master@{#395019}

Powered by Google App Engine
This is Rietveld 408576698