Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 19996003: Update gyp DEPS (Closed)

Created:
7 years, 5 months ago by borenet
Modified:
7 years, 5 months ago
Reviewers:
epoger, rmistry, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
borenet
This includes my gyp change to allow generating projects on a different drive in Windows ...
7 years, 5 months ago (2013-07-22 20:38:28 UTC) #1
djsollen
does the gyp team have branches or tags you can follow? My guess is probably ...
7 years, 5 months ago (2013-07-22 20:49:48 UTC) #2
borenet
On 2013/07/22 20:49:48, djsollen wrote: > does the gyp team have branches or tags you ...
7 years, 5 months ago (2013-07-22 20:51:39 UTC) #3
djsollen
lgtm
7 years, 5 months ago (2013-07-23 14:44:22 UTC) #4
borenet
Committed patchset #1 manually as r10266 (presubmit successful).
7 years, 5 months ago (2013-07-23 14:47:00 UTC) #5
epoger
On 2013/07/22 20:49:48, djsollen wrote: > does the gyp team have branches or tags you ...
7 years, 5 months ago (2013-07-23 15:05:34 UTC) #6
djsollen
Yes, there is the possiblity that they could change what the tag alaiases to from ...
7 years, 5 months ago (2013-07-23 15:14:27 UTC) #7
epoger
7 years, 5 months ago (2013-07-23 15:28:51 UTC) #8
Message was sent while issue was closed.
On 2013/07/23 15:14:27, djsollen wrote:
> Yes, there is the possiblity that they could change what the tag alaiases to
> from under you, but there are some branches/tags that can be assumed to be
> fixed.  For example the AOSP (android open-source) has tags for major releases
> (e.g. 4.2.2) which is expected not to change.

Aha, as documented at
http://source.android.com/source/build-numbers.html#source-code-tags-and-builds
, an example tag on that tree is "android-4.2.2_r1".  Nice that they maintain
those.

Powered by Google App Engine
This is Rietveld 408576698