Update chrome://device-emulator with newer Polymer guidelines

Update chrome://device-emulator with newer Polymer guidelines

Lots of changes from recent Polymer updates. Also freshen up the style
a little, make dialogs close on Escape, remove dependency on iron-icons.

New screenshot (not much changed visually) in the bug.

Note that this only applies to non-official Debug builds.

After this I'll add new settings, e.g. pointer settings.

BUG=613416
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a
Cr-Commit-Position: refs/heads/master@{#395248}

[michaelpg, 2016-05-20 01:44:02]

Description was changed from

==========
Update chrome://device-emulator with newer Polymer guidelines

Lots of changes from recent Polymer updates. Also freshen up the style
a little, make dialogs close on Escape, remove dependency on iron-icons.

Note that this only applies to non-official Debug builds.

After this I'll add new settings, e.g. pointer settings.

BUG=613416
==========

to

==========
Update chrome://device-emulator with newer Polymer guidelines

Lots of changes from recent Polymer updates. Also freshen up the style
a little, make dialogs close on Escape, remove dependency on iron-icons.

Note that this only applies to non-official Debug builds.

After this I'll add new settings, e.g. pointer settings.

BUG=613416
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-20 01:45:00]

Description was changed from

==========
Update chrome://device-emulator with newer Polymer guidelines

Lots of changes from recent Polymer updates. Also freshen up the style
a little, make dialogs close on Escape, remove dependency on iron-icons.

Note that this only applies to non-official Debug builds.

After this I'll add new settings, e.g. pointer settings.

BUG=613416
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Update chrome://device-emulator with newer Polymer guidelines

Lots of changes from recent Polymer updates. Also freshen up the style
a little, make dialogs close on Escape, remove dependency on iron-icons.

New screenshot (not much changed visually) in the bug.

Note that this only applies to non-official Debug builds.

After this I'll add new settings, e.g. pointer settings.

BUG=613416
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-20 01:45:00]

michaelpg@chromium.org changed reviewers:
+ stevenjb@chromium.org

[michaelpg, 2016-05-20 01:55:38]

PTAL (but don't look too hard, it's a debug UI)

[stevenjb, 2016-05-20 15:56:46]

lgtm with one nit and one change request.

https://codereview.chromium.org/1999593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/emulator/audio_settings.html (right):

https://codereview.chromium.org/1999593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/emulator/audio_settings.html:16: <!--
TODO(michaelpg): https://github.com/Polymer/polymer/pull/3668 -->
nit: todo what exactly (without having to follow the link and parse the change)

https://codereview.chromium.org/1999593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/emulator/device_emulator_pages.js
(right):

https://codereview.chromium.org/1999593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/emulator/device_emulator_pages.js:27:
chrome.send('initialize');
How about initializeDeviceEmulator? I know that only the send calls associated
with the page are active, but it's still a global namespace. (It also makes
searching for the associated C++ file much easier).

[michaelpg, 2016-05-20 21:28:29]

Addressed feedback, added a paper-icon-button to toggle the drawer (otherwise
you can't change pages in narrow mode), used OnJavascript[Dis]allowed.

https://codereview.chromium.org/1999593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/emulator/audio_settings.html (right):

https://codereview.chromium.org/1999593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/emulator/audio_settings.html:16: <!--
TODO(michaelpg): https://github.com/Polymer/polymer/pull/3668 -->
On 2016/05/20 15:56:46, stevenjb wrote:
> nit: todo what exactly (without having to follow the link and parse the
change)

Done.

https://codereview.chromium.org/1999593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/emulator/device_emulator_pages.js
(right):

https://codereview.chromium.org/1999593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/emulator/device_emulator_pages.js:27:
chrome.send('initialize');
On 2016/05/20 15:56:46, stevenjb wrote:
> How about initializeDeviceEmulator? I know that only the send calls associated
> with the page are active, but it's still a global namespace. (It also makes
> searching for the associated C++ file much easier).

Done.

[stevenjb, 2016-05-20 22:00:36]

still lgtm

[michaelpg, 2016-05-21 00:24:15]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-05-21 00:24:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999593002/60001

[commit-bot: I haz the power, 2016-05-21 02:53:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-21 02:53:44]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2016-05-21 04:07:25]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-05-21 04:07:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999593002/60001

[commit-bot: I haz the power, 2016-05-21 04:48:20]

Description was changed from

==========
Update chrome://device-emulator with newer Polymer guidelines

Lots of changes from recent Polymer updates. Also freshen up the style
a little, make dialogs close on Escape, remove dependency on iron-icons.

New screenshot (not much changed visually) in the bug.

Note that this only applies to non-official Debug builds.

After this I'll add new settings, e.g. pointer settings.

BUG=613416
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Update chrome://device-emulator with newer Polymer guidelines

Lots of changes from recent Polymer updates. Also freshen up the style
a little, make dialogs close on Escape, remove dependency on iron-icons.

New screenshot (not much changed visually) in the bug.

Note that this only applies to non-official Debug builds.

After this I'll add new settings, e.g. pointer settings.

BUG=613416
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-21 04:48:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-21 04:49:31]

Description was changed from

==========
Update chrome://device-emulator with newer Polymer guidelines

Lots of changes from recent Polymer updates. Also freshen up the style
a little, make dialogs close on Escape, remove dependency on iron-icons.

New screenshot (not much changed visually) in the bug.

Note that this only applies to non-official Debug builds.

After this I'll add new settings, e.g. pointer settings.

BUG=613416
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Update chrome://device-emulator with newer Polymer guidelines

Lots of changes from recent Polymer updates. Also freshen up the style
a little, make dialogs close on Escape, remove dependency on iron-icons.

New screenshot (not much changed visually) in the bug.

Note that this only applies to non-official Debug builds.

After this I'll add new settings, e.g. pointer settings.

BUG=613416
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a
Cr-Commit-Position: refs/heads/master@{#395248}
==========

[commit-bot: I haz the power, 2016-05-21 04:49:32]

Patchset 4 (id:??) landed as
https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a
Cr-Commit-Position: refs/heads/master@{#395248}