OOPIFs: Fixing submitting forms targeting a remote frame.

third_party/WebKit/Source/core/loader/FormSubmission.cpp

Index: third_party/WebKit/Source/core/loader/FormSubmission.cpp
diff --git a/third_party/WebKit/Source/core/loader/FormSubmission.cpp b/third_party/WebKit/Source/core/loader/FormSubmission.cpp
index e66fa9eba1a541a5b91e5a9ac14bb03b67eecd9a..741a01f522c2edc651abb77192955ae87a5f6176 100644
--- a/third_party/WebKit/Source/core/loader/FormSubmission.cpp
+++ b/third_party/WebKit/Source/core/loader/FormSubmission.cpp
@@ -275,18 +275,23 @@ void FormSubmission::populateFrameLoadRequest(FrameLoadRequest& frameRequest)
     if (!m_target.isEmpty())
         frameRequest.setFrameName(m_target);
 
+    populateResourceRequest(frameRequest.resourceRequest());
+}
+
+void FormSubmission::populateResourceRequest(ResourceRequest& resourceRequest)

[Nate Chapin, 2016/06/07 21:35:51]

Maybe have this return a ResourceRequest instead of populating an existing one?

[Łukasz Anforowicz, 2016/06/08 20:32:43]

Good idea.  Let me change
    void FormSubmission::populateFrameLoadRequest(FrameLoadRequest&)
into
    FrameLoadRequest FormSubmission::createFrameLoadRequest(Document*
originDocument)

+{
     if (m_method == FormSubmission::PostMethod) {
-        frameRequest.resourceRequest().setHTTPMethod("POST");
-        frameRequest.resourceRequest().setHTTPBody(m_formData);
+        resourceRequest.setHTTPMethod("POST");
+        resourceRequest.setHTTPBody(m_formData);
 
         // construct some user headers if necessary
         if (m_boundary.isEmpty())
-            frameRequest.resourceRequest().setHTTPContentType(m_contentType);
+            resourceRequest.setHTTPContentType(m_contentType);
         else
-            frameRequest.resourceRequest().setHTTPContentType(m_contentType + "; boundary=" + m_boundary);
+            resourceRequest.setHTTPContentType(m_contentType + "; boundary=" + m_boundary);
     }
 
-    frameRequest.resourceRequest().setURL(requestURL());
+    resourceRequest.setURL(requestURL());
 }
 
 } // namespace blink