third_party/WebKit/Source/core/loader/FormSubmission.cpp - Issue 1999573003: OOPIFs: Fixing submitting forms targeting a remote frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FormSubmission.cpp

Issue 1999573003: OOPIFs: Fixing submitting forms targeting a remote frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@form-target-is-cross-site-frame

Patch Set: populate... -> createFrameLoadRequest + going through RemoteFrame::navigate(FrameLoadRequest&) Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/FormSubmission.h ('K') | « third_party/WebKit/Source/core/loader/FormSubmission.h ('k') | third_party/WebKit/Source/core/loader/FrameLoadRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FormSubmission.cpp

diff --git a/third_party/WebKit/Source/core/loader/FormSubmission.cpp b/third_party/WebKit/Source/core/loader/FormSubmission.cpp

index e66fa9eba1a541a5b91e5a9ac14bb03b67eecd9a..94ab53b9ed23aa08d16a46f6886d2922175653c0 100644

--- a/third_party/WebKit/Source/core/loader/FormSubmission.cpp

+++ b/third_party/WebKit/Source/core/loader/FormSubmission.cpp

@@ -270,8 +270,10 @@ KURL FormSubmission::requestURL() const

return requestURL;

}

-void FormSubmission::populateFrameLoadRequest(FrameLoadRequest& frameRequest)

+FrameLoadRequest FormSubmission::createFrameLoadRequest(Document* originDocument)

{

+ FrameLoadRequest frameRequest(originDocument);

if (!m_target.isEmpty())

frameRequest.setFrameName(m_target);

@@ -287,6 +289,11 @@ void FormSubmission::populateFrameLoadRequest(FrameLoadRequest& frameRequest)

}

frameRequest.resourceRequest().setURL(requestURL());

+ frameRequest.setTriggeringEvent(m_event);

+ frameRequest.setForm(m_form);

Łukasz Anforowicz 2016/06/08 20:32:43 These 2 statements have been moved here from Sched

+ return frameRequest;

}

} // namespace blink