third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post.html - Issue 1999573003: OOPIFs: Fixing submitting forms targeting a remote frame.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post.html

Issue 1999573003: OOPIFs: Fixing submitting forms targeting a remote frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@form-target-is-cross-site-frame

Patch Set: Added a TODO for investigating if remote and local frames can be handled uniformly. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-get-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 The test verifies that a form with target="crossSiteFrame" works fine	3 The test verifies that a form with target="crossSiteFrame" works fine

4 (especially in presence of out-of-process-iframes, aka OOPIFs, aka	4 (especially in presence of out-of-process-iframes, aka OOPIFs, aka

5 blink::RemoteFrames which are present in --site-per-process mode).	5 blink::RemoteFrames which are present in --site-per-process mode).

6	6

7 The test finishes successfully, if form-target.pl ends up calling	7 The test finishes successfully, if form-target.pl ends up calling

8 testRunner.notifyDone() after main frame calls testRuner.waitUntilDone	8 testRunner.notifyDone() after main frame calls testRuner.waitUntilDone

9 and submits the form. Expected test output helps verify that the	9 and submits the form. Expected test output helps verify that the

10 correct HTTP method was used and that test field's value from the form	10 correct HTTP method was used and that test field's value from the form

(...skipping 19 matching lines...) Expand all Loading...
30 target="cross-site-frame">	30 target="cross-site-frame">

31 Test field:	31 Test field:

32 <input name="test-field" type="text" value="test-value">	32 <input name="test-field" type="text" value="test-value">

33 <input type="submit" value="Submit">	33 <input type="submit" value="Submit">

34 </form>	34 </form>

35 <iframe	35 <iframe

36 name="cross-site-frame"	36 name="cross-site-frame"

37 src="https://localhost:8443/navigation/resources/form-target.pl"></iframe>	37 src="https://localhost:8443/navigation/resources/form-target.pl"></iframe>

38 </body>	38 </body>

39 </html>	39 </html>

OLD	NEW