Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1999573002: Revert of QUIC - minor debugging logic to see why SCT verification is failing when (Closed)

Created:
4 years, 7 months ago by ramant (doing other things)
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - minor debugging logic to see why SCT verification is failing when (patchset #2 id:20001 of https://codereview.chromium.org/1949333002/ ) Reason for revert: Reverting debugging logic. Original issue's description: > QUIC - minor debugging logic to see why SCT verification is failing when > QUIC is accessed from home. > > Will delete this code asap. > > R=rch@chromium.org > > Committed: https://crrev.com/3903514d7dda980ff099152f69bdfb4964c6c707 > Cr-Commit-Position: refs/heads/master@{#391950} TBR=rch@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/a5b15047f682f5f7436b28ed67fb355d9055b66c Cr-Commit-Position: refs/heads/master@{#394975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M net/quic/crypto/proof_verifier_chromium.cc View 1 chunk +3 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
ramant (doing other things)
Created Revert of QUIC - minor debugging logic to see why SCT verification is failing ...
4 years, 7 months ago (2016-05-20 01:27:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999573002/1
4 years, 7 months ago (2016-05-20 01:28:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999573002/1
4 years, 7 months ago (2016-05-20 01:32:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999573002/1
4 years, 7 months ago (2016-05-20 02:01:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999573002/1
4 years, 7 months ago (2016-05-20 02:31:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999573002/1
4 years, 7 months ago (2016-05-20 03:01:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 03:14:09 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5b15047f682f5f7436b28ed67fb355d9055b66c Cr-Commit-Position: refs/heads/master@{#394975}
4 years, 7 months ago (2016-05-20 03:15:19 UTC) #9
Will Harris
4 years, 4 months ago (2016-07-28 21:37:07 UTC) #10
Message was sent while issue was closed.
is there any concern that this debug logic ended up in M52 branch 2743 since the
revert happened after branch point?

https://chromium.googlesource.com/chromium/src/+/52.0.2743.109/net/quic/crypt...

(trying trace down issue 632157)

Powered by Google App Engine
This is Rietveld 408576698