Delay asm->wasm foreign globals init until later.

Delay asm->wasm foreign globals init until later.

Rather than bake foreign globals into the module
at compile time, add a __foreign_init__ function that can be called
after instantiation with foreign values gathers using keys
in a separately generated FixedArray.

This is an incremental step towards being able to enable asm->wasm
on for general traffic, behind a flag.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=asm-wasm
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/48c2857a931097595cb175b186e872c226f37ff7
Cr-Commit-Position: refs/heads/master@{#36418}

[titzer, 2016-05-20 11:39:59]

https://codereview.chromium.org/1999523002/diff/20001/src/wasm/asm-wasm-build...
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1999523002/diff/20001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:896: foreign_variables_.push_back(foreign);
Could you just do push_back({...})?

https://codereview.chromium.org/1999523002/diff/20001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:1730: struct ForeignVariable {
Can you move this to the top?

https://codereview.chromium.org/1999523002/diff/20001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:1733: bool is_float;
Should we store the AST type here instead of a boolean?

[bradn, 2016-05-20 14:37:31]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-05-20 14:37:32]

PTAL

https://codereview.chromium.org/1999523002/diff/20001/src/wasm/asm-wasm-build...
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1999523002/diff/20001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:896: foreign_variables_.push_back(foreign);
On 2016/05/20 11:39:59, titzer wrote:
> Could you just do push_back({...})?

Done.

https://codereview.chromium.org/1999523002/diff/20001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:1730: struct ForeignVariable {
On 2016/05/20 11:39:59, titzer wrote:
> Can you move this to the top?

Done.

https://codereview.chromium.org/1999523002/diff/20001/src/wasm/asm-wasm-build...
src/wasm/asm-wasm-builder.cc:1733: bool is_float;
On 2016/05/20 11:39:59, titzer wrote:
> Should we store the AST type here instead of a boolean?

Done.

[titzer, 2016-05-20 15:25:45]

lgtm

[bradn, 2016-05-20 15:31:15]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-05-20 15:31:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999523002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999523002/40001

[commit-bot: I haz the power, 2016-05-20 15:33:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 15:37:31]

Description was changed from

==========
Delay asm->wasm foreign globals init until later.

Rather than bake foreign globals into the module
at compile time, add a __foreign_init__ function that can be called
after instantiation with foreign values gathers using keys
in a separately generated FixedArray.

This is an incremental step towards being able to enable asm->wasm
on for general traffic, behind a flag.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=asm-wasm
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Delay asm->wasm foreign globals init until later.

Rather than bake foreign globals into the module
at compile time, add a __foreign_init__ function that can be called
after instantiation with foreign values gathers using keys
in a separately generated FixedArray.

This is an incremental step towards being able to enable asm->wasm
on for general traffic, behind a flag.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=asm-wasm
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/48c2857a931097595cb175b186e872c226f37ff7
Cr-Commit-Position: refs/heads/master@{#36418}
==========

[commit-bot: I haz the power, 2016-05-20 15:37:32]

Patchset 3 (id:??) landed as
https://crrev.com/48c2857a931097595cb175b186e872c226f37ff7
Cr-Commit-Position: refs/heads/master@{#36418}