Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3180)

Unified Diff: chrome/BUILD.gn

Issue 1999513002: [Mac/GN] Implement dSYM generation and stripping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment++ Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/mac/linker_driver.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 6fb3011e30b37472da5828c3bb5e8ec69028e2e1..d8d0b770ec9317b782c6e3370267bfe5dd724a32 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -21,6 +21,7 @@ if (is_android) {
} else if (is_mac) {
import("//build/compiled_action.gni")
import("//build/config/mac/rules.gni")
+ import("//build/config/mac/symbols.gni")
import("//build/mac/tweak_info_plist.gni")
import("//build/util/branding.gni")
import("//build/util/version.gni")
@@ -455,6 +456,15 @@ if (is_win) {
":chrome_versioned_bundle_data",
"//chrome/common:version_header",
]
+
+ # Remove the default strip configuration (which strips all symbols) so that
+ # a saves file can be specified.
+ if (enable_stripping) {
+ remove_configs = [ "//build/config/mac:strip_all" ]
+
+ ldflags =
+ [ "-Wcrl,strip,-s," + rebase_path("app/app.saves", root_build_dir) ]
+ }
}
compiled_action("chrome_app_strings") {
@@ -597,6 +607,15 @@ if (is_win) {
"-rpath",
"@loader_path/../../../../../../..",
]
+
+ # Remove the default strip configuration (which strips all symbols) so that
+ # a saves file can be specified.
+ if (enable_stripping) {
+ remove_configs = [ "//build/config/mac:strip_all" ]
+
+ ldflags +=
+ [ "-Wcrl,strip,-s," + rebase_path("app/app.saves", root_build_dir) ]
+ }
}
bundle_data("chrome_framework_locales") {
« no previous file with comments | « build/toolchain/mac/linker_driver.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698