[Mac/GN] Implement dSYM generation and stripping.

chrome/BUILD.gn

Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 6fb3011e30b37472da5828c3bb5e8ec69028e2e1..d8d0b770ec9317b782c6e3370267bfe5dd724a32 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -21,6 +21,7 @@ if (is_android) {
 } else if (is_mac) {
   import("//build/compiled_action.gni")
   import("//build/config/mac/rules.gni")
+  import("//build/config/mac/symbols.gni")
   import("//build/mac/tweak_info_plist.gni")
   import("//build/util/branding.gni")
   import("//build/util/version.gni")
@@ -455,6 +456,15 @@ if (is_win) {
       ":chrome_versioned_bundle_data",
       "//chrome/common:version_header",
     ]
+
+    # Remove the default strip configuration (which strips all symbols) so that
+    # a saves file can be specified.
+    if (enable_stripping) {
+      remove_configs = [ "//build/config/mac:strip_all" ]
+
+      ldflags =
+          [ "-Wcrl,strip,-s," + rebase_path("app/app.saves", root_build_dir) ]

[brettw, 2016/06/03 20:23:25]

The file app/app.saves should be added as an input or something to this step so
that when it's changed this step is re-run. I'm not sure if mac_app_bundle has
the concept of "inputs" that aren't bundled, so we may need to add this.

[Robert Sesek, 2016/06/03 20:46:14]

We've hit this issue before with the .order file to the linker. No solution yet,
but there's a bug: https://bugs.chromium.org/p/chromium/issues/detail?id=612623

+    }
   }
 
   compiled_action("chrome_app_strings") {
@@ -597,6 +607,15 @@ if (is_win) {
       "-rpath",
       "@loader_path/../../../../../../..",
     ]
+
+    # Remove the default strip configuration (which strips all symbols) so that
+    # a saves file can be specified.
+    if (enable_stripping) {
+      remove_configs = [ "//build/config/mac:strip_all" ]
+
+      ldflags +=
+          [ "-Wcrl,strip,-s," + rebase_path("app/app.saves", root_build_dir) ]

[brettw, 2016/06/03 20:23:25]

Ditto

+    }
   }
 
   bundle_data("chrome_framework_locales") {