Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 1999513002: [Mac/GN] Implement dSYM generation and stripping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Global configuration Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/mac/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 92d0b6e12877497f30aafe083d2a08da38e4b4e7..341be421ff9adf7e8ca8ecf80d92a25b9e774827 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -508,6 +508,8 @@ if (is_win) {
# that shouldn't use the windows subsystem.
"//build/config/win:console",
]
+} else if (is_mac) {
+ _mac_linker_configs = [ "//build/config/mac:strip_all" ]
Dirk Pranke 2016/05/31 19:58:19 It might make more sense to have a single generic
Robert Sesek 2016/06/01 20:21:05 If I do (in //build/config/mac/BUILD.gn): config(
Dirk Pranke 2016/06/01 21:16:54 Yeah, I wasn't sure if that would work or not. Fai
}
# Executable defaults.
@@ -517,6 +519,8 @@ _executable_configs = _native_compiler_configs + [
]
if (is_win) {
_executable_configs += _windows_linker_configs
+} else if (is_mac) {
+ _executable_configs += _mac_linker_configs
}
set_defaults("executable") {
configs = _executable_configs
@@ -540,6 +544,8 @@ if (is_win) {
# want this can remove this config.
_shared_library_configs +=
[ "//build/config/android:hide_native_jni_exports" ]
+} else if (is_mac) {
+ _shared_library_configs += _mac_linker_configs
}
set_defaults("shared_library") {
configs = _shared_library_configs
« no previous file with comments | « no previous file | build/config/mac/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698