Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1999493003: Count usage of :read-only and :read-write CSS selectors. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Count usage of :read-only and :read-write CSS selectors. This CL has no user-visible behavior changes. BUG=613378 TBR=isherman@chromium.org Committed: https://crrev.com/0ad2dca465ede4f0bef9a4ff5f5acc04da4979a1 Cr-Commit-Position: refs/heads/master@{#394989}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
tkent
timloh@, would you review this please?
4 years, 7 months ago (2016-05-19 23:46:06 UTC) #2
Timothy Loh
On 2016/05/19 23:46:06, tkent wrote: > timloh@, would you review this please? lgtm
4 years, 7 months ago (2016-05-19 23:53:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999493003/1
4 years, 7 months ago (2016-05-20 00:59:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/187004)
4 years, 7 months ago (2016-05-20 01:17:15 UTC) #9
tkent
TBRing isherman for histograms.xml.
4 years, 7 months ago (2016-05-20 01:20:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999493003/20001
4 years, 7 months ago (2016-05-20 01:21:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 03:51:19 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0ad2dca465ede4f0bef9a4ff5f5acc04da4979a1 Cr-Commit-Position: refs/heads/master@{#394989}
4 years, 7 months ago (2016-05-20 03:52:38 UTC) #16
Ilya Sherman
4 years, 7 months ago (2016-05-20 04:02:46 UTC) #17
Message was sent while issue was closed.
histograms.xml lgtm

Powered by Google App Engine
This is Rietveld 408576698