Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1999483002: Correct in-line comment (Closed)

Created:
4 years, 7 months ago by mike3
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correct in-line comment Commit c86f189 corrected the way context from which a specific error is thrown, but the in-line comment was not updated to reflect this. Update the comment to accurately describe the intended behavior. LOG=N R=littledan@chromium.org BUG= Committed: https://crrev.com/34c202a0c1f4aa200417c0be562791dacc12cc45 Cr-Commit-Position: refs/heads/master@{#36541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mike3
4 years, 7 months ago (2016-05-19 21:36:45 UTC) #1
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-05-27 09:04:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999483002/1
4 years, 6 months ago (2016-05-27 09:04:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 09:53:47 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 09:54:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34c202a0c1f4aa200417c0be562791dacc12cc45
Cr-Commit-Position: refs/heads/master@{#36541}

Powered by Google App Engine
This is Rietveld 408576698