delete the levelDB storage implementation.

delete the levelDB storage implementation.

BUG=NONE

Committed: https://crrev.com/344bb7e95cb1619d98c15e1456c0044365e6c233
Cr-Commit-Position: refs/heads/master@{#395371}

[bburns, 2016-05-19 23:42:16]

bburns@chromium.org changed reviewers:
+ dimich@chromium.org, fgorski@chromium.org

[bburns, 2016-05-19 23:42:17]

I left the parameterized testing stuff in place as an example, and in case we
ever do this again.

I can rip it out if you prefer.

Thanks!
--brendan

[Dmitry Titov, 2016-05-20 05:36:32]

-myself, fgorski@ is the right reviewer here.

[fgorski, 2016-05-20 15:33:44]

It looks good overall. You are missing removal of the protobuf and related build
stuff.

https://code.google.com/p/chromium/codesearch#chromium/src/components/offline...

[bburns, 2016-05-20 18:11:51]

On 2016/05/20 15:33:44, fgorski wrote:
> It looks good overall. You are missing removal of the protobuf and related
build
> stuff.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/offline...

Done.  Please take another look.

--brendan

[fgorski, 2016-05-20 18:14:43]

lgtm mod update to DEPS file.

[bburns, 2016-05-23 16:45:05]

The CQ bit was checked by bburns@chromium.org

[bburns, 2016-05-23 16:45:05]

The patchset sent to the CQ was uploaded after l-g-t-m from fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/1999443003/#ps80001
(title: "remove proto headers")

[commit-bot: I haz the power, 2016-05-23 16:45:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999443003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999443003/80001

[commit-bot: I haz the power, 2016-05-23 18:39:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-23 18:40:51]

Description was changed from

==========
delete the levelDB storage implementation.

BUG=NONE
==========

to

==========
delete the levelDB storage implementation.

BUG=NONE

Committed: https://crrev.com/344bb7e95cb1619d98c15e1456c0044365e6c233
Cr-Commit-Position: refs/heads/master@{#395371}
==========

[commit-bot: I haz the power, 2016-05-23 18:40:53]

Patchset 5 (id:??) landed as
https://crrev.com/344bb7e95cb1619d98c15e1456c0044365e6c233
Cr-Commit-Position: refs/heads/master@{#395371}

[Marijn Kruisselbrink, 2016-05-23 19:12:09]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2007523003/ by mek@chromium.org.

The reason for reverting is: This seems to be causing compile failures on Win
x64 (at least this seems the only remotely plausible candidate...):

https://build.chromium.org/p/chromium/builders/Win%20x64/builds/925/steps/com...

FAILED:
obj/components/offline_pages/offline_pages.offline_page_storage_manager.obj 
ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc
"C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe"
/nologo /showIncludes /FC
@obj\components\offline_pages\offline_pages.offline_page_storage_manager.obj.rsp
/c ..\..\components\offline_pages\offline_page_storage_manager.cc
/Foobj\components\offline_pages\offline_pages.offline_page_storage_manager.obj
/Fdobj\components\offline_pages.cc.pdb 
c:\b\build\slave\win_x64\build\src\components\offline_pages\offline_page_storage_manager.cc(83):
error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64\build\src\components\offline_pages\offline_page_storage_manager.cc(83):
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss
of data
c:\b\build\slave\win_x64\build\src\base\bind_internal.h(186): warning C4267:
'argument': conversion from 'size_t' to 'int', possible loss of data
c:\b\build\slave\win_x64\build\src\base\bind_internal.h(324): note: see
reference to function template instantiation 'R
base::internal::RunnableAdapter<T>::Run<offline_pages::OfflinePageStorageManager*,const
offline_pages::OfflinePageStorageManager::ClearPageCallback&,const unsigned
__int64&,_Ty>(Receiver &&,const
offline_pages::OfflinePageStorageManager::ClearPageCallback &,const unsigned
__int64 &,_Ty &&)' being compiled
.

[bburns, 2016-05-23 19:16:47]

On 2016/05/23 19:12:09, Marijn Kruisselbrink wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/2007523003/ by mailto:mek@chromium.org.
> 
> The reason for reverting is: This seems to be causing compile failures on Win
> x64 (at least this seems the only remotely plausible candidate...):
> 
>
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/925/steps/com...
> 
> FAILED:
> obj/components/offline_pages/offline_pages.offline_page_storage_manager.obj 
> ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc
>
"C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe"
> /nologo /showIncludes /FC
>
@obj\components\offline_pages\offline_pages.offline_page_storage_manager.obj.rsp
> /c ..\..\components\offline_pages\offline_page_storage_manager.cc
> /Foobj\components\offline_pages\offline_pages.offline_page_storage_manager.obj
> /Fdobj\components\offline_pages.cc.pdb 
>
c:\b\build\slave\win_x64\build\src\components\offline_pages\offline_page_storage_manager.cc(83):
> error C2220: warning treated as error - no 'object' file generated
>
c:\b\build\slave\win_x64\build\src\components\offline_pages\offline_page_storage_manager.cc(83):
> warning C4267: 'initializing': conversion from 'size_t' to 'int', possible
loss
> of data
> c:\b\build\slave\win_x64\build\src\base\bind_internal.h(186): warning C4267:
> 'argument': conversion from 'size_t' to 'int', possible loss of data
> c:\b\build\slave\win_x64\build\src\base\bind_internal.h(324): note: see
> reference to function template instantiation 'R
>
base::internal::RunnableAdapter<T>::Run<offline_pages::OfflinePageStorageManager*,const
> offline_pages::OfflinePageStorageManager::ClearPageCallback&,const unsigned
> __int64&,_Ty>(Receiver &&,const
> offline_pages::OfflinePageStorageManager::ClearPageCallback &,const unsigned
> __int64 &,_Ty &&)' being compiled
> .

This passed that build:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64...

So it's hard for me to see how this needs to be reverted...