Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1999423002: tyrbot test for commitText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SetHasCompositionTextToTrue Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index c547c8c767170d02438378aa81fe7a7c1540fdd7..4c6951069a6ec868130b7e5606b668343af30769 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -141,9 +141,8 @@ public:
const WebVector<WebCompositionUnderline>& underlines,
int selectionStart,
int selectionEnd) override;
- bool confirmComposition() override;
- bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) override;
- bool confirmComposition(const WebString& text) override;
+ bool commitText(const WebString& text, int relativeCaretPosition) override;
+ bool finishComposingText(ConfirmCompositionBehavior selectionBehavior) override;
WebRange compositionRange() override;
WebTextInputInfo textInputInfo() override;
WebTextInputType textInputType() override;
@@ -564,8 +563,6 @@ private:
// Returns true if the event was actually processed.
bool keyEventDefault(const WebKeyboardEvent&);
- bool confirmComposition(const WebString& text, ConfirmCompositionBehavior);
-
// Returns true if the view was scrolled.
bool scrollViewWithKeyboard(int keyCode, int modifiers);
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698