Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.h

Issue 1999423002: tyrbot test for commitText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SetHasCompositionTextToTrue Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.h
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
index 210214a58ee885d6607fc7cb172a7076f91662cd..6aa082b31d28d7a7c5341c55f8e7ec2335714e17 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
@@ -98,9 +98,8 @@ public:
const WebString& text,
const WebVector<WebCompositionUnderline>& underlines,
int selectionStart, int selectionEnd) override;
- bool confirmComposition() override;
- bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) override;
- bool confirmComposition(const WebString& text) override;
+ bool commitText(const WebString& text, int relativeCaretPosition) override;
+ bool finishComposingText(ConfirmCompositionBehavior selectionBehavior) override;
WebRange compositionRange() override;
WebTextInputInfo textInputInfo() override;
WebTextInputType textInputType() override;
@@ -206,8 +205,6 @@ private:
// focused frame has a different local root.
LocalFrame* focusedLocalFrameInWidget() const;
- bool confirmComposition(const WebString& text, ConfirmCompositionBehavior selectionBehavior) const;
-
WebPlugin* focusedPluginIfInputMethodSupported(LocalFrame*) const;
WebString inputModeOfFocusedElement() const;

Powered by Google App Engine
This is Rietveld 408576698