Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 199933002: Revert of Replace --ppapi-keep-alive-throttle command line switch with IPC parameter. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Revert of Replace --ppapi-keep-alive-throttle command line switch with IPC parameter. (https://codereview.chromium.org/197693003/) Reason for revert: Broke building on http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28x86%29%20ASan/builds/8599/steps/BuildPackages/logs/stdio This bot builds with disable_nacl=1 for some reason (mentioned in the stdio above somewhere – not sure why this is), and thus chrome_browser doesn't depend on nacl_browser, leading to this linker error when building browser_tests: chromeos-chrome-35.0.1889.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/extensions/app_background_page_apitest.cc:134: error: undefined reference to 'nacl::NaClProcessHost::SetPpapiKeepAliveThrottleForTesting(unsigned int)' (Maybe this change generally breaks building browser_tests with disable_nacl=1?) Original issue's description: > Replace --ppapi-keep-alive-throttle command line switch with IPC parameter. > > Part of a broad effort to reduce the number of command line switches. > > This is the second land of this change - correcting a static initializer issue. > > BUG=350510 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256961 TBR=dmichael@chromium.org,tsepez@chromium.org,mseaborn@chromium.org,scheib@chromium.org NOTREECHECKS=true NOTRY=true BUG=350510 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -62 lines) Patch
M chrome/browser/extensions/app_background_page_apitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/nacl/browser/nacl_process_host.h View 2 chunks +0 lines, -6 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 4 chunks +2 lines, -13 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_globals.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_globals.cc View 5 chunks +16 lines, -8 lines 0 comments Download
M ppapi/proxy/plugin_main_irt.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/shared_impl/ppapi_constants.h View 1 chunk +0 lines, -19 lines 0 comments Download
M ppapi/shared_impl/ppapi_nacl_plugin_args.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppapi_nacl_plugin_args.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ppapi/shared_impl/ppapi_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Created Revert of Replace --ppapi-keep-alive-throttle command line switch with IPC parameter.
6 years, 9 months ago (2014-03-14 05:00:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/199933002/1
6 years, 9 months ago (2014-03-14 05:01:46 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 05:03:02 UTC) #3
Message was sent while issue was closed.
Change committed as 256993

Powered by Google App Engine
This is Rietveld 408576698